From: Andreas Ericsson <ae@op5.se>
To: Junio C Hamano <gitster@pobox.com>
Cc: "H.Merijn Brand" <h.m.brand@xs4all.nl>, git@vger.kernel.org
Subject: Re: [PATCH] HP-UX does not have select.h
Date: Tue, 18 Dec 2007 10:30:55 +0100 [thread overview]
Message-ID: <4767934F.7070706@op5.se> (raw)
In-Reply-To: <7v8x3t6nq1.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
>
> Besides, isn't _HPUX_SOURCE a feature-test macro? Feature test macros
> are for the application to define, and for the implementation (iow, the
> header files) to find out what set of names the application wants to
> see. You are making the application examine the symbol to see what
> implementation it is on, which feels backwards to me.
#if defined(hpux) || defined(_hpux) || defined(__hpux)
should work ok, although as you say, trying
#if _POSIX_VERSION < 200112
# include <non-POSIX.1-2001 headers>
#else
# include <sys/select.h>
#endif
would probably be more suitable.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2007-12-18 9:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 18:23 [PATCH] HP-UX does not have select.h H.Merijn Brand
2007-12-17 21:00 ` Junio C Hamano
2007-12-17 22:22 ` H.Merijn Brand
2007-12-18 5:29 ` Junio C Hamano
2007-12-18 7:11 ` H.Merijn Brand
2007-12-18 8:16 ` Johannes Sixt
2007-12-18 12:38 ` Johannes Schindelin
2007-12-18 12:45 ` Johannes Sixt
2007-12-18 13:53 ` Johannes Schindelin
2007-12-18 14:22 ` Johannes Sixt
2007-12-18 9:30 ` Andreas Ericsson [this message]
2007-12-18 9:47 ` Junio C Hamano
2007-12-18 10:49 ` H.Merijn Brand
2007-12-19 19:57 ` Junio C Hamano
2007-12-19 20:12 ` H.Merijn Brand
2007-12-19 21:31 ` Junio C Hamano
2007-12-20 7:18 ` H.Merijn Brand
2007-12-20 7:52 ` Junio C Hamano
2007-12-23 8:37 ` Jan Hudec
2007-12-23 8:59 ` H.Merijn Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4767934F.7070706@op5.se \
--to=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=h.m.brand@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.