All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Saeed Bishara <saeed@marvell.com>
Cc: linux-ide@vger.kernel.org, saeed.bishara@gmail.com,
	htejun@gmail.com, liml@rtr.ca
Subject: Re: [PATCH 1/1] [LibATA] sata_mv: Remove dumplicated host template
Date: Tue, 18 Dec 2007 16:48:48 -0500	[thread overview]
Message-ID: <47684040.8000105@garzik.org> (raw)
In-Reply-To: <11978143164051-git-send-email-saeed@marvell.com>

Saeed Bishara wrote:
> The mv5_sht and mv6_sht structures are identical. This patch removes one of
> those structures and renames the other to mv_sht.
> 
> Signed-off-by: Saeed Bishara <saeed@marvell.com>
> ---
>  drivers/ata/sata_mv.c |   22 ++--------------------
>  1 files changed, 2 insertions(+), 20 deletions(-)

Quite true -- but we must re-add mv6_sht once NCQ support is added. 
Therefore I'll drop this patch for now.

Mark Lord is working on this (at the behest of Marvell, I believe).  I 
also created a preliminary NON-WORKING implementation of NCQ that I made 
available to Mark as a starting point:

Branch 'mv-ncq' of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git

If nothing happens in six months, we can revisit your patch :)

Regards,

	Jeff




      reply	other threads:[~2007-12-18 21:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-16 14:11 [PATCH 1/1] [LibATA] sata_mv: Remove dumplicated host template Saeed Bishara
2007-12-18 21:48 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47684040.8000105@garzik.org \
    --to=jeff@garzik.org \
    --cc=htejun@gmail.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    --cc=saeed.bishara@gmail.com \
    --cc=saeed@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.