All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Ranostay <mranostay@embeddedalley.com>
To: alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>,
	Tim Gardner <tim.gardner@canonical.com>,
	Jose_De_La_Rosa@Dell.com
Subject: [PATCH] Dmux mixer conflict
Date: Tue, 18 Dec 2007 17:40:05 -0500	[thread overview]
Message-ID: <47684C45.2080601@embeddedalley.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

DMUX mixers need to be created before input source mixers, otherwise 
some STAC9228 codecs fail to record correctly or at all.

---
Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>

[-- Attachment #2: dmux_mixer.patch --]
[-- Type: text/plain, Size: 732 bytes --]

diff -r fbe3540c8df4 pci/hda/patch_sigmatel.c
--- a/pci/hda/patch_sigmatel.c	Tue Dec 18 18:05:52 2007 +0100
+++ b/pci/hda/patch_sigmatel.c	Tue Dec 18 15:27:34 2007 -0700
@@ -834,15 +834,16 @@ static int stac92xx_build_controls(struc
 	if (err < 0)
 		return err;
 
-	for (i = 0; i < spec->num_mixers; i++) {
-		err = snd_hda_add_new_ctls(codec, spec->mixers[i]);
-		if (err < 0)
-			return err;
-	}
 	if (spec->num_dmuxes > 0) {
 		stac_dmux_mixer.count = spec->num_dmuxes;
 		err = snd_ctl_add(codec->bus->card,
 				  snd_ctl_new1(&stac_dmux_mixer, codec));
+		if (err < 0)
+			return err;
+	}
+
+	for (i = 0; i < spec->num_mixers; i++) {
+		err = snd_hda_add_new_ctls(codec, spec->mixers[i]);
 		if (err < 0)
 			return err;
 	}

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

             reply	other threads:[~2007-12-18 22:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-18 22:40 Matthew Ranostay [this message]
2007-12-19  9:27 ` [PATCH] Dmux mixer conflict Takashi Iwai
2007-12-19 14:07   ` Matthew Ranostay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47684C45.2080601@embeddedalley.com \
    --to=mranostay@embeddedalley.com \
    --cc=Jose_De_La_Rosa@Dell.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tim.gardner@canonical.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.