From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <haveblue@us.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page
Date: Thu, 20 Dec 2007 23:09:58 +0530 [thread overview]
Message-ID: <476AA8EE.1000206@linux.vnet.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0712201715160.16967@blonde.wat.veritas.com>
Hugh Dickins wrote:
> On Thu, 20 Dec 2007, Andrew Morton wrote:
>> On Thu, 20 Dec 2007 21:54:15 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>>> I was going to say the same thing, page_get_page_cgroup() does not hold
>>> any references. May be _get_ in the name is confusing.
>> It is a bit unconventional. page_cgroup()?
>
> Seems ideal to me
> (though there is some argument for page_page_cgroup(), weird as it is).
>
> Hugh
Sounds good to me as well, except that it sounds like a constructor :-)
I'll try and make the changes and submit a patch. I am in the middle of
losing control_type now (based on Hugh's comments)
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
prev parent reply other threads:[~2007-12-20 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 6:18 [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page Balbir Singh
2007-12-19 17:14 ` Dave Hansen
2007-12-20 13:14 ` Hugh Dickins
2007-12-20 13:51 ` Peter Zijlstra
2007-12-20 14:16 ` Hugh Dickins
2007-12-20 14:20 ` Peter Zijlstra
2007-12-20 16:24 ` Balbir Singh
2007-12-20 16:35 ` Dave Hansen
2007-12-20 17:12 ` Andrew Morton
2007-12-20 17:21 ` Hugh Dickins
2007-12-20 17:39 ` Balbir Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476AA8EE.1000206@linux.vnet.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=haveblue@us.ibm.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.