From: Arjan van de Ven <arjan@linux.intel.com>
To: David Newall <david@davidnewall.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Marcel Holtmann <marcel@holtmann.org>,
linux-kernel@vger.kernel.org
Subject: Re: Kernel bug: bluetooth meets TTY layer
Date: Thu, 20 Dec 2007 21:17:10 +0100 [thread overview]
Message-ID: <476ACDC6.8070904@linux.intel.com> (raw)
In-Reply-To: <476AC51F.70400@davidnewall.com>
David Newall wrote:
> Hi Arjan,
>
> I've not been able to find this file, "drivers/bluetooth/hci_tty.c", but
> anyway, This seems to be what happens: Hci_uart_close() flushes using
> hci_uart_flush(). Subsequently, in hci_dev_do_close(), (one step in
> hci_unregister_dev()), hci_uart_flush() is called again. The comment in
> uart_flush_buffer(), relating to the WARN_ON(), indicates you can't
> flush after the port is closed; which sounds reasonable. I think
> hci_uart_close() should set hdev->flush to NULL before returning.
> Hci_dev_do_close() does check for this. The code path is rather
> involved and I'm not entirely clear of all steps, but I think that's
> what should be done.
>
> Patch for stupidly obsolete kernel attached.
looks reasonable; unfortunately I don't know the tty code well enough to judge this patch...
Alan?
next prev parent reply other threads:[~2007-12-20 20:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 15:25 Kernel bug: bluetooth meets TTY layer Arjan van de Ven
2007-12-20 19:40 ` David Newall
2007-12-20 20:17 ` Arjan van de Ven [this message]
2007-12-20 21:26 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476ACDC6.8070904@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=david@davidnewall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.