All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
To: lvm-devel@redhat.com
Subject: [PATCH 1/4] Fix '--nosync' option of lvcreate and remove unnecessary tag collection
Date: Fri, 21 Dec 2007 20:22:57 -0500	[thread overview]
Message-ID: <476C66F1.7020803@ce.jp.nec.com> (raw)

This patch fixes 2 things.

While converting lvcreate to use the newly added lv_add_mirrors(),
I mistakenly moved the MIRROR_NOTSYNCED flag setting *after*
lv_create_empty().
As a result, '--nosync' option of lvcreate becomes nop.
This patch moves the flag setting and makes nosync option working again.

In the old code, tag list is created and passed for mirror log creation
function because the log was created before the LV.
In the current code, linear LV is created first and the log creation
function takes tag list from the LV. So we don't need to create
tag list in lvcreate.

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: revive-nosync-option.patch
Type: text/x-patch
Size: 1701 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20071221/e5e7b214/attachment.bin>

                 reply	other threads:[~2007-12-22  1:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=476C66F1.7020803@ce.jp.nec.com \
    --to=j-nomura@ce.jp.nec.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.