From: Eric Sandeen <sandeen@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel Mailing List <linux-kernel@vger.kernel.org>,
Michael Halcrow <mhalcrow@us.ibm.com>,
mike@halcrow.us, Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH] (UPDATED) ecryptfs: check for existing key_tfm at mount time
Date: Sat, 22 Dec 2007 23:56:57 -0600 [thread overview]
Message-ID: <476DF8A9.3080401@redhat.com> (raw)
In-Reply-To: <20071222162516.df6fe557.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Sat, 22 Dec 2007 11:42:37 -0600 Eric Sandeen <sandeen@redhat.com> wrote:
>
>> Andrew Morton wrote:
>>
>>> It would all look a lot more solid if this locking was retained and both
>>> ecryptfs_tfm_exists() and ecryptfs_add_new_key_tfm() were designed to be
>>> called under key_tfm_list_mutex.
>> Hmm good point, sorry for missing that. How's this look?
>
> key_tfm_list_mutex gets used in fs/ecryptfs/main.c but it is static in
> fs/ecryptfs/crypto.c
>
Ah crud that was a bunk-ism in -mm that I missed.
I'll send another updated patch soon.
-Eric
next prev parent reply other threads:[~2007-12-23 5:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 5:18 [PATCH] ecryptfs: check for existing key_tfm at mount time Eric Sandeen
2007-12-21 15:01 ` Michael Halcrow
2007-12-22 4:56 ` Andrew Morton
2007-12-22 17:42 ` [PATCH] (UPDATED) " Eric Sandeen
2007-12-23 0:25 ` Andrew Morton
2007-12-23 5:56 ` Eric Sandeen [this message]
2007-12-23 17:26 ` [PATCH] (UPDATED2) " Eric Sandeen
2008-01-07 22:08 ` [PATCH] (UPDATED3) " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476DF8A9.3080401@redhat.com \
--to=sandeen@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
--cc=mike@halcrow.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.