From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Sieka Date: Thu, 27 Dec 2007 21:36:09 +0100 Subject: [U-Boot-Users] [patch] do not use linux/string.h in sha1.c on hosts In-Reply-To: <20071227201516.9F2712405E@gemini.denx.de> References: <20071227201516.9F2712405E@gemini.denx.de> Message-ID: <47740CB9.1070708@semihalf.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message <4773FCEF.2040507@semihalf.com> you wrote: >>>> But IIRC mkimage does not use any sha1 code ... >>> the Makefile claims otherwise ... patch attached to remove sha1.o from mkimage >>> linking since it isnt actually used. > > Indeed the Makefile contained a not needed reference. > >> It is likely we'll need sha1 support in mkimage for the new uImage >> format. Let's wait with this patch until mkimage extension to the new >> uImage format is settled down. > > I'm not so sure. Maybe it's better to clean up now, and deal with the > new image format requirements when we're at it. Please note that the > mkimage code has recenty been added to the Linux kernel tree, and > there the sha1 reference was also removed. I think it makes sense to > keep both in sync... I think it makes sense, too. I am fine with having the clean-up now, and adding sha1 later on when needed. Regards, Barlomiej