From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: adeos-main <adeos-main@gna.org>
Subject: Re: [Adeos-main] fastcall and asmlinkage in x86
Date: Fri, 28 Dec 2007 16:43:14 +0100 [thread overview]
Message-ID: <47751992.9030302@domain.hid> (raw)
In-Reply-To: <477505A5.6070900@domain.hid>
Jan Kiszka wrote:
> Hi Philippe,
>
> most of the code in arch/x86/ipipe_*.c can be pushed into some
> ipipe-common.c, reducing the patch size by 10-20k and improving code
> maintainability.
>
> But one thing is currently blocking a copy&paste move: a lot of
> functions that are declared fastcall on 32 bit are asmlinkage on 64 bit.
2.4/x86 legacy that survived.
> As both asmlinkage and fastcall are meaningless on 64 bit, can we safely
> switch to fastcall?
Yes.
Or even better, could we drop that redundant
> declarations totally, given that everything is fastcall on 32 bit anyway
> (unless its marked asmlinkage)?
>
I see -mregparm=3 unconditionally set in arch/x86/Makefile_32, so this
should work. Looking at some assembly call sites (exception
handling/diversion) tends to confirm this; AFAIR we should not have any
regparm(0) code anywhere. Well, if we still do have some, you will be
the first to know...
--
Philippe.
prev parent reply other threads:[~2007-12-28 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-28 14:18 [Adeos-main] fastcall and asmlinkage in x86 Jan Kiszka
2007-12-28 15:43 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47751992.9030302@domain.hid \
--to=rpm@xenomai.org \
--cc=adeos-main@gna.org \
--cc=jan.kiszka@domain.hid \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.