All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com,
	Narcisa.Vasile@microsoft.com, talshn@nvidia.com, "Burakov,
	Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal: enable windows apps to run on non-admin users
Date: Tue, 03 Nov 2020 21:28:22 +0100	[thread overview]
Message-ID: <4776239.YslOQH0Lb5@thomas> (raw)
In-Reply-To: <8a3139b8-3a03-1f98-69c1-e3c38fb5fa4d@intel.com>

28/10/2020 13:41, Burakov, Anatoly:
> On 26-Oct-20 6:44 PM, Pallavi Kadam wrote:
> > Currently, since there is no runtime directory set, the code tries to
> > create a file in C:\ which is only writable with administrator
> > privileges. As a result, if the user is not admin, the application will
> > fail.
> > So, forcing no_shconf to 1 to prevent the code having to create files in
> > the runtime directory.
> > 
> > Suggested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> > Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> > ---
> >   		internal_conf->in_memory = 1;
> > +		internal_conf->no_shconf = 1;
> 
> This is the correct way, as in-memory implies no_shconf. I would like to 
> deprecate noshconf option as it's a subset of what in-memory does.
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks



  reply	other threads:[~2020-11-03 20:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21 20:26 [dpdk-dev] [PATCH] eal: create a runtime directory on windows Pallavi Kadam
2020-10-22 18:15 ` Ranjit Menon
2020-10-22 19:05 ` Dmitry Kozlyuk
2020-10-26 19:01   ` Kadam, Pallavi
2020-10-26 18:44 ` [dpdk-dev] [PATCH v2] eal: enable windows apps to run on non-admin users Pallavi Kadam
2020-10-27 23:10   ` Dmitry Kozlyuk
2020-10-28 12:41   ` Burakov, Anatoly
2020-11-03 20:28     ` Thomas Monjalon [this message]
2020-10-29 18:37   ` Narcisa Ana Maria Vasile

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4776239.YslOQH0Lb5@thomas \
    --to=thomas@monjalon.net \
    --cc=Narcisa.Vasile@microsoft.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=pallavi.kadam@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=talshn@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.