Re: udev no longer passes USB device remove events

["Anthony L. Awtrey" <tony@awtrey.com>]

Hello again,

I fixed my problem, but not the right way. One thing that tripped me
when I was investigating this issue was that when you issue a
"udevcontrol log_priorityÞbug" you don't actually get dbg() messages
in the syslog. Therefore my log dump looked like silent failure to me.
Once I found the function I suspected to cause the trouble, I changed
the dgb() functions to info() and could see this:

udev_node_remove: device node '/dev/bus/usb/004/007' not found

It looks like udev is failing to remove a non-existant device node and
returning -1. Raw USB devices don't necessarily have device nodes to
remove, so the perfectly reasonable "remove usb" events are failing for
no good reason that I can tell.

I fixed my problem by allowing the function udev_node_remove() to return
0 on device node remove failures:

...
int udev_node_remove(struct udevice *udev)
{
        char filename[PATH_SIZE];
        char partitionname[PATH_SIZE];
        struct stat stats;
        int retval = 0;
        int num;

        strlcpy(filename, udev_root, sizeof(filename));
        strlcat(filename, "/", sizeof(filename));
        strlcat(filename, udev->name, sizeof(filename));
        if (stat(filename, &stats) != 0) {
                dbg("device node '%s' not found", filename);
                return 0; /* <--- LOOK */
        }
...

I don't know the other implications, but it appears to work and does not
cause any other obvious problems in my limited testing. Can anyone
suggest a more appropriate fix?

Tony



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel