From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1J8lRx-0000A9-AA for mharc-grub-devel@gnu.org; Sat, 29 Dec 2007 18:50:41 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J8lRu-00009u-O1 for grub-devel@gnu.org; Sat, 29 Dec 2007 18:50:38 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J8lRs-00009i-DA for grub-devel@gnu.org; Sat, 29 Dec 2007 18:50:37 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J8lRs-00009f-7j for grub-devel@gnu.org; Sat, 29 Dec 2007 18:50:36 -0500 Received: from pne-smtpout3-sn2.hy.skanova.net ([81.228.8.111]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J8lRr-0002bj-Ko for grub-devel@gnu.org; Sat, 29 Dec 2007 18:50:35 -0500 Received: from [127.0.0.1] (88.193.32.97) by pne-smtpout3-sn2.hy.skanova.net (7.3.129) id 471A5695003A4CE3 for grub-devel@gnu.org; Sun, 30 Dec 2007 00:49:51 +0100 Message-ID: <4776DD49.7030406@nic.fi> Date: Sun, 30 Dec 2007 01:50:33 +0200 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: The development of GRUB 2 References: <20071223210936.GA27776@thorin> <20071224012818.GA22510@thorin> <20071224013530.GA22710@thorin> In-Reply-To: <20071224013530.GA22710@thorin> X-Enigmail-Version: 0.95.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) Subject: Re: gfxterm / grub_virtual_screen_setcolorstate() X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Dec 2007 23:50:39 -0000 Robert Millan wrote: > On Mon, Dec 24, 2007 at 02:28:18AM +0100, Robert Millan wrote: >> New patch. Corrects a minor mistake when filling the last colum in the >> menu. Also, it doesn't change the colors on gfxterm since some reasjustments >> were needed for that, and there's also a bug that makes it impossible to >> change colors on the fly with gfxterm/vbe (I'll write more on that later). > > This patch (relative to previous one) basicaly makes it work with a big > ugly kludge (see "| 0xff000000" line). The problem seems to be that alpha > channel is set to 0 for all return values of grub_video_map_color() after > gfxterm initialization. I checked the few places in the code where those > variables are zeroed, but to no avail. I assume the problem is just they > haven't been initialised, but I just have no idea where they're supposed to. > > Any clues? Ok... Your "fix" with OR'ing is not a good one as that makes an assumption about display mode settings. Idea of mapping colors is to get most optimal color settings for desired video mode. Nevertheless I think I know the problem and I get back to you shortly... now I sleep :) That zero alpha setting most likely comes from color table being specified. (or from video mode settings currently in use, eg. no alpha/reserved bits)