All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Thomas Bogendoerfer <tbogendoerfer@suse.de>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	"Ertman, David M" <david.m.ertman@intel.com>
Subject: Re: [PATCH net-next] ice: rephrase LLDP filter fallback message
Date: Fri, 21 Aug 2026 13:59:26 -0700	[thread overview]
Message-ID: <477734d9-ed8e-4696-8160-382b29e7491c@intel.com> (raw)
In-Reply-To: <20260717084453.9521-1-tbogendoerfer@suse.de>



On 7/17/2026 1:44 AM, Thomas Bogendoerfer wrote:
> Seeing an error message in a logfile triggers scripts/admins thinking of
> problems. The LLDP fallback message itself is not an error, it just
> indicates it's using a different filter mechanism. So rephrase to a
> less "scary" message.

Hi Thomas,

I believe this patch [1] will remove the need for this change. Could 
test it and confirm that it will work for you?

Thanks,
Tony

[1] 
https://lore.kernel.org/intel-wired-lan/20260811181127.1142095-1-david.m.ertman@intel.com/ 

> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> ---
>   drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
> index 8cdc4fda89e9..59341b5a0c05 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
> @@ -2097,7 +2097,7 @@ void ice_vsi_cfg_sw_lldp(struct ice_vsi *vsi, bool tx, bool create)
>   				goto report;
>   
>   			dev_info(dev,
> -				 "Failed to add generic LLDP Rx filter on VSI %i error: %d, falling back to specialized AQ control\n",
> +				 "Using generic LLDP Rx filter on VSI %i is not possible (%d), falling back to specialized AQ control\n",
>   				 vsi->vsi_num, status);
>   		}
>   


  parent reply	other threads:[~2026-08-21 20:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  8:44 [PATCH net-next] ice: rephrase LLDP filter fallback message Thomas Bogendoerfer
2026-07-17  8:44 ` [Intel-wired-lan] " Thomas Bogendoerfer
2026-07-23  9:21 ` Loktionov, Aleksandr
2026-07-23  9:21   ` Loktionov, Aleksandr
2026-08-05 18:31 ` Arland, ArpanaX
2026-08-05 18:31   ` Arland, ArpanaX
2026-08-21 20:59 ` Tony Nguyen [this message]
2026-08-24  8:45   ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=477734d9-ed8e-4696-8160-382b29e7491c@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=david.m.ertman@intel.com \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=tbogendoerfer@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.