From: "H. Peter Anvin" <hpa@zytor.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@us.ibm.com>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: Introduce REX prefix helper for kprobes
Date: Sat, 29 Dec 2007 23:04:52 -0800 [thread overview]
Message-ID: <47774314.9080406@zytor.com> (raw)
In-Reply-To: <47773C2D.8070600@redhat.com>
Masami Hiramatsu wrote:
> Hi Harvey,
>
> Harvey Harrison wrote:
>> Fold some small ifdefs into a helper function.
>>
>> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
>> ---
>> Masami, Ingo, I had this left in some unsent kprobes unification
>> work. Depends on your tastes, but does reduce ifdefs and is a bit
>> better about self-documenting the REX prefix on X86_64.
>
> Basically, I think it is good idea.
> Could you use a macro same as the stack_addr() macro, like as below?
>
> #defile is_REX_prefix(insn) ((insn & 0xf0) == 0x40))
>
> This is just a bit checker, so I think a macro is better to do that.
>
Why is a macro better than an inline, and why the odd mIXed case?
-hpa
next prev parent reply other threads:[~2007-12-30 7:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 3:26 [PATCH] x86: Introduce REX prefix helper for kprobes Harvey Harrison
2007-12-30 6:35 ` Masami Hiramatsu
2007-12-30 7:04 ` H. Peter Anvin [this message]
2007-12-30 8:01 ` Masami Hiramatsu
2007-12-30 8:31 ` Masami Hiramatsu
2007-12-30 13:19 ` Ingo Molnar
2007-12-30 17:39 ` Harvey Harrison
2007-12-30 13:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47774314.9080406@zytor.com \
--to=hpa@zytor.com \
--cc=ananth@in.ibm.com \
--cc=harvey.harrison@gmail.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.