Re: [Adeos-main] [PATCH 3/5] avoid naming conflict around __ipipe_irq_handler

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

Philippe Gerum wrote:
> Jan Kiszka wrote:
>> There is already a definition of __ipipe_irq_handler. So, we either need
>> to more the real ipipe_irq_handler_t into ipipe_base.h, or rename this
>> local variant to __ipipe_irq_handler_t, or simple drop this refactoring.
>> This patch starts with applying the latter - the easiest one :->
>>
> 
> There is no naming conflict, since they describe the same type with
> different even if close names on purpose. __ipipe_irq_handler is only a

Sorry for remaining unclear: I was referring to the __ipipe_irq_handler
helper macro from linux/ipipe.h. They may happen to live happily side by
side, but it is far from being clean.

> local short-hand to reduce visual pollution; as a matter of fact, the
> assembly code itself depends on the handler prototype, despite it cannot
> rely on any C-defined type, so the problem - if any - starts even before
> this local definition, and if you happen to change ipipe_irq_handler_t,
> then you could just not miss fixing __ipipe_irq_handler in the same move.
> 
> The only sane way to avoid defining this short-hand is indeed to move
> ipipe_irq_handler_t to linux/ipipe_base.h.
> 

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]