All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuai Xue <xueshuai@linux.alibaba.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: lukas@wunner.de, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org, helgaas@kernel.org,
	bhelgaas@google.com, tony.luck@intel.com, bp@alien8.de,
	mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
	oleg@redhat.com, naveen@kernel.org, davem@davemloft.net,
	anil.s.keshavamurthy@intel.com, mark.rutland@arm.com,
	peterz@infradead.org, tianruidong@linux.alibaba.com
Subject: Re: [PATCH v5] PCI: hotplug: Add a generic RAS tracepoint for hotplug event
Date: Tue, 11 Mar 2025 10:06:56 +0800	[thread overview]
Message-ID: <47785d3f-3560-4832-b88a-031a80d1fd28@linux.alibaba.com> (raw)
In-Reply-To: <20250310105044.129dc354@gandalf.local.home>



在 2025/3/10 22:50, Steven Rostedt 写道:
> On Mon, 10 Mar 2025 11:59:55 +0800
> Shuai Xue <xueshuai@linux.alibaba.com> wrote:
> 
>> Hi, Steve,
>>
>> If I move PCI_HOTPLUG_EVENT into one place, `include/upai/linux/pci.h`,
>> I need to include:
>>
>>       #include <linux/tracepoint.h>
>>
>> Then, kernel build fails with CONFIG_UAPI_HEADER_TEST=y:
> 
> Just move the enum definitions, not the entire event file.
> 
> That is, have one place has the PCI_HOTPLUG_EVENT macro, and have both the
> uapi header as well as the tracepoint header include that header.
> 
> I guess I need to see the entire change.
> 

Hi, Steven,

IMHO, the problem is that the PCI_HOTPLUG_EVENT macro needs to include
"linux/tracepoint.h" but it is not allowed in userspace.

The entire change in v6 build fails with CONFIG_UAPI_HEADER_TEST=y:

   https://lore.kernel.org/lkml/202501190108.tRReJA1Z-lkp@intel.com/T/#mae507b91b8b80c386dfa9e63fbbdd45826c2e003

(sorry, I did not see the problem because my local .config do not set
CONFIG_UAPI_HEADER_TEST)

Thanks
Shuai

      reply	other threads:[~2025-03-11  2:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09  2:55 [PATCH v5] PCI: hotplug: Add a generic RAS tracepoint for hotplug event Shuai Xue
2025-01-13 20:55 ` Steven Rostedt
2025-01-14 11:47   ` Shuai Xue
2025-03-10  3:59   ` Shuai Xue
2025-03-10 14:50     ` Steven Rostedt
2025-03-11  2:06       ` Shuai Xue [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47785d3f-3560-4832-b88a-031a80d1fd28@linux.alibaba.com \
    --to=xueshuai@linux.alibaba.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=davem@davemloft.net \
    --cc=helgaas@kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=naveen@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tianruidong@linux.alibaba.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.