From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1J9gxB-0002Bp-R4 for mharc-grub-devel@gnu.org; Tue, 01 Jan 2008 08:14:45 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J9gxA-0002Bk-CW for grub-devel@gnu.org; Tue, 01 Jan 2008 08:14:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J9gx9-0002BO-KF for grub-devel@gnu.org; Tue, 01 Jan 2008 08:14:44 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J9gx9-0002B8-BH for grub-devel@gnu.org; Tue, 01 Jan 2008 08:14:43 -0500 Received: from pne-smtpout4-sn1.fre.skanova.net ([81.228.11.168]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J9gx9-0002ED-1q for grub-devel@gnu.org; Tue, 01 Jan 2008 08:14:43 -0500 Received: from [127.0.0.1] (88.193.32.97) by pne-smtpout4-sn1.fre.skanova.net (7.3.129) id 474FD0210016E914 for grub-devel@gnu.org; Tue, 1 Jan 2008 14:14:25 +0100 Message-ID: <477A3CCA.4090908@nic.fi> Date: Tue, 01 Jan 2008 15:14:50 +0200 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: The development of GRUB 2 References: <20080101124728.GA30417@thorin> In-Reply-To: <20080101124728.GA30417@thorin> X-Enigmail-Version: 0.95.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) Subject: Re: [PATCH] allow user-configurable menucolor X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jan 2008 13:14:44 -0000 Robert Millan wrote: > This patch allows the following to work: > > set color_normal=cyan/blue > set color_highlight=white/blue > > which is equivalent to this command in GRUB Legacy: > > color cyan/blue white/blue > > I haven't written a ChangeLog entry yet, because I'd like to receive comments > on the function names. I don't really like `parse_single_color_name' and > `parse_color_name' but I don't know what to call them :-(. What conventions > are there for referring to single colors (i.e. those that describe only FG or > only BG, not both) and complete colors (FG + BG) ? First some questions ;) - What happens when you forgot to provide / in this string ;) ? - What happens when all memory is used? - What happens when you alter list of colors... remove one entry of it or add one. (eg. hard coding is bad... sizeof...) Now to your naming issue... This code is quite specific to be only local so I would propose following: parse_single_color_name -> parse_color_name parse_color_name -> parse_color_tuple, parse_color_pair, parse_text_color or parse_menu_color Ideally these would be superseded by theming but should work as temporary code until this feature is implemented. That being said... I would be too concerned about its naming :)