From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1J9lT0-0001D0-5h for mharc-grub-devel@gnu.org; Tue, 01 Jan 2008 13:03:54 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J9lSz-0001CS-Kb for grub-devel@gnu.org; Tue, 01 Jan 2008 13:03:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J9lSx-00018M-7V for grub-devel@gnu.org; Tue, 01 Jan 2008 13:03:52 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J9lSx-00018J-2c for grub-devel@gnu.org; Tue, 01 Jan 2008 13:03:51 -0500 Received: from mailout08.sul.t-online.de ([194.25.134.20] helo=mailout08.sul.t-online.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J9lSw-0008BD-IX for grub-devel@gnu.org; Tue, 01 Jan 2008 13:03:50 -0500 Received: from fwd27.aul.t-online.de by mailout08.sul.t-online.com with smtp id 1J9lSv-0000t5-02; Tue, 01 Jan 2008 19:03:49 +0100 Received: from [10.3.2.2] (XL+SRmZXghhhKhRMvApj4KOoFcdeThgbX8WsAORxr9vpB5mnueQ0SYzLJoPzdosgfr@[217.235.196.196]) by fwd27.aul.t-online.de with esmtp id 1J9lSj-1lgJTk0; Tue, 1 Jan 2008 19:03:37 +0100 Message-ID: <477A8078.60901@t-online.de> Date: Tue, 01 Jan 2008 19:03:36 +0100 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: The development of GRUB 2 References: <471E4628.9030706@t-online.de> <20071118112737.GB16674@thorin> <474202DA.4010001@t-online.de> <47790D50.4060000@t-online.de> <20080101111652.GA8608@thorin> <477A77D9.9020607@t-online.de> <20080101174434.GB3440@thorin> In-Reply-To: <20080101174434.GB3440@thorin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: XL+SRmZXghhhKhRMvApj4KOoFcdeThgbX8WsAORxr9vpB5mnueQ0SYzLJoPzdosgfr X-TOI-MSGID: 287e39db-0a71-4559-b961-203b4783c993 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jan 2008 18:03:53 -0000 Robert Millan wrote: >>> ... >>> >> This part is intended to handle the (normal) case of one continuous >> region with not gap between 1M and 16M: >> (0x3C00 << 10) = 0x100000 * 15 = 15M >> But this part does not work due to the same bug. >> >> It is IMO not necessary to make this distinction. The function >> compact_mem_regions() called a few lines later joins the two regions anyway. >> > > Ah, ok. Have you verified that this is so? (setting debug=mem variable > during init might help on that). > > Yes. During testing, I temporarily added some diagnostic output. The function compact_mem_regions() works as expected. > Sorry for being so inquisitive, but I need to understand things well before > touching this part of GRUB, which as I said I'm not very familiar with. > > A wrong memory map would break grub, therefore these parts should be changed very carefully :-) Christian