From: "Rémi Hérilier" <rherilier@yahoo.fr>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: linux-kernel@vger.kernel.org, dtor@mail.ru, linux-input@vger.kernel.org
Subject: Re: PATCH] adding wistron_btns support for X86_64 systems.
Date: Wed, 02 Jan 2008 23:31:09 +0100 [thread overview]
Message-ID: <477C10AD.7060303@yahoo.fr> (raw)
In-Reply-To: <200712222040.14422.carlos@strangeworlds.co.uk>
Carlos Corbacho wrote:
> (CC'ing linux-input, as that is the relevant subsystem list for wistron-btns).
>
> Rémi Hérilier wrote:
>> To use my previous patch (wistron_btns support for fujitsu-siemens amilo
>> pro edition v3505) with my laptop, I need to make the wistron module
>> compile for x86_64. It is based on Linux 2.4.24-rc4 too.
>
> NAK.
>
> You cannot make 32 bit BIOS calls in a 64 bit OS.
>
> This will (and does) segfault on x86-64 (tested on my Aspire 5020, where
> call_bios wistron-btns just segfaults on x86-64 with this patch).
>
> This is a known issue, and the reason why wistron-btns (and the out-of-tree
> acerhk) have not been ported to x86-64.
>
> -Carlos
Yes, in theory, this must segfault on x86-64.
In pratice, there is one laptop where it seems to works (no problem
for 3 weeks). A good reason to find why.
Best regards
Remi Herilier
-
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Rémi Hérilier" <rherilier@yahoo.fr>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: linux-kernel@vger.kernel.org, dtor@mail.ru, linux-input@vger.kernel.org
Subject: Re: PATCH] adding wistron_btns support for X86_64 systems.
Date: Wed, 02 Jan 2008 23:31:09 +0100 [thread overview]
Message-ID: <477C10AD.7060303@yahoo.fr> (raw)
In-Reply-To: <200712222040.14422.carlos@strangeworlds.co.uk>
Carlos Corbacho wrote:
> (CC'ing linux-input, as that is the relevant subsystem list for wistron-btns).
>
> Rémi Hérilier wrote:
>> To use my previous patch (wistron_btns support for fujitsu-siemens amilo
>> pro edition v3505) with my laptop, I need to make the wistron module
>> compile for x86_64. It is based on Linux 2.4.24-rc4 too.
>
> NAK.
>
> You cannot make 32 bit BIOS calls in a 64 bit OS.
>
> This will (and does) segfault on x86-64 (tested on my Aspire 5020, where
> call_bios wistron-btns just segfaults on x86-64 with this patch).
>
> This is a known issue, and the reason why wistron-btns (and the out-of-tree
> acerhk) have not been ported to x86-64.
>
> -Carlos
Yes, in theory, this must segfault on x86-64.
In pratice, there is one laptop where it seems to works (no problem
for 3 weeks). A good reason to find why.
Best regards
Remi Herilier
next prev parent reply other threads:[~2008-01-03 0:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-22 20:40 PATCH] adding wistron_btns support for X86_64 systems Carlos Corbacho
2007-12-22 20:40 ` Carlos Corbacho
2008-01-02 22:31 ` Rémi Hérilier [this message]
2008-01-02 22:31 ` Rémi Hérilier
2008-01-03 16:21 ` Dmitry Torokhov
2008-01-03 16:21 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2007-12-06 20:16 Rémi Hérilier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477C10AD.7060303@yahoo.fr \
--to=rherilier@yahoo.fr \
--cc=carlos@strangeworlds.co.uk \
--cc=dtor@mail.ru \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.