From: Sunil Mushran <Sunil.Mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Re: [Ocfs2-tools-devel] [PATCH 3/6] Abstract checking and validating process in tunefs.ocfs2.take 3
Date: Wed Jan 2 19:03:30 2008 [thread overview]
Message-ID: <477C501F.3010309@oracle.com> (raw)
In-Reply-To: <20071218011317.GA23447@tma-pc1.cn.oracle.com>
Tao Ma wrote:
> In the main function of tunefs.ocfs2, there are a large
> number of checking and validating process. They are seperated
> and can be moved out of "main" so that future online resize
> can skip these check easily. So add 2 new function, volume_check
> and validate_parameter to organize the complicated process.
>
> There are also 2 minor changes in this patch:
> 1. the print of "Adding backup superblock for the volume" are moved to
> validate process as others.
> 2. remove_slot_check is moved into function volume_check as it does
> the check work while it was in validate process.
>
> Signed-off-by: Tao Ma <tao.ma@oracle.com>
> --
Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
Remind me... some of the error messages need some polishing.
Nothing big. I can handle that later.
next prev parent reply other threads:[~2008-01-02 19:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 17:09 [Ocfs2-devel] [PATCH 0/6] Add online resize for ocfs2-tools,take 3 tao.ma
2007-12-17 17:16 ` [Ocfs2-devel] [PATCH 2/6] Abstract some specific process in resize to some individual function.take 3 Tao Ma
2008-01-02 19:01 ` [Ocfs2-devel] Re: [Ocfs2-tools-devel] " Sunil Mushran
2007-12-17 17:16 ` [Ocfs2-devel] [PATCH 3/6] Abstract checking and validating process in tunefs.ocfs2.take 3 Tao Ma
2008-01-02 19:03 ` Sunil Mushran [this message]
2007-12-17 17:16 ` [Ocfs2-devel] [PATCH 4/6] Modfiy cl_cpg in global_bitmap to be maximum value during mkfs.take 3 Tao Ma
2008-01-02 19:03 ` [Ocfs2-devel] Re: [Ocfs2-tools-devel] " Sunil Mushran
2007-12-17 17:16 ` [Ocfs2-devel] [PATCH 1/6] Move resize function out of tunefs.c, take 3 Tao Ma
2007-12-17 17:36 ` Mark Fasheh
2008-01-02 19:01 ` [Ocfs2-devel] Re: [Ocfs2-tools-devel] " Sunil Mushran
2007-12-17 17:18 ` [Ocfs2-devel] [PATCH 6/6] Add online resize support in tunefs.ocfs2.take 3 Tao Ma
2007-12-17 17:18 ` [Ocfs2-devel] [PATCH 5/6] Modify fsck to trust global bitmap than super block.take 3 Tao Ma
2007-12-17 17:34 ` [Ocfs2-devel] Re: [Ocfs2-tools-devel] " Mark Fasheh
2008-01-02 19:05 ` Sunil Mushran
2008-01-02 19:17 ` tao.ma
2008-01-02 19:40 ` Sunil Mushran
2008-01-02 20:29 ` tao.ma
2008-01-03 18:30 ` Sunil Mushran
2008-01-04 0:41 ` tao.ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477C501F.3010309@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.