From: Boaz Harrosh <bharrosh@panasas.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jens Axboe <jens.axboe@oracle.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/3] scsi: Convert everyone to scsi_sglist and scsi_sg_count
Date: Thu, 03 Jan 2008 11:26:13 +0200 [thread overview]
Message-ID: <477CAA35.3020900@panasas.com> (raw)
In-Reply-To: <200801031950.12090.rusty@rustcorp.com.au>
On Thu, Jan 03 2008 at 10:50 +0200, Rusty Russell <rusty@rustcorp.com.au> wrote:
> This patch simply converts direct uses of ->use_sg and ->request_buffer to
> use the wrapper macros. This removes the assumption that the sg list is
> overloaded on request_buffer, and that there's an explicit use_sg field.
>
> The ->request_buffer assumption is explicit in scsi_debug.c's paranoid
> checking, so that code had to be shuffled a little.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
> drivers/scsi/NCR5380.c | 6 +++---
> drivers/scsi/NCR53C9x.c | 6 +++---
> drivers/scsi/aha1542.c | 14 +++++++-------
> drivers/scsi/atari_NCR5380.c | 2 +-
> drivers/scsi/atp870u.c | 22 +++++++++++-----------
> drivers/scsi/eata_pio.c | 6 +++---
> drivers/scsi/fd_mcs.c | 6 +++---
> drivers/scsi/imm.c | 5 ++---
> drivers/scsi/in2000.c | 6 +++---
> drivers/scsi/libsrp.c | 12 ++++++------
> drivers/scsi/pcmcia/nsp_cs.c | 8 ++++----
> drivers/scsi/ppa.c | 4 ++--
> drivers/scsi/qlogicpti.c | 12 ++++++------
> drivers/scsi/scsi_debug.c | 14 +++++++-------
> drivers/scsi/seagate.c | 4 ++--
> drivers/scsi/sr.c | 6 +++---
> drivers/scsi/sun3_NCR5380.c | 6 +++---
> drivers/scsi/sun3x_esp.c | 4 ++--
> drivers/scsi/wd33c93.c | 6 +++---
> 21 files changed, 77 insertions(+), 76 deletions(-)
>
All of these drivers are properly converted in current scsi-misc + scsi-pending.
If you are really serious about changing scsi-layer you better work ontop of
scsi git trees.
Also you can inspect -mm tree it has the scsi_data_buffer patches that does
4/5 what you want.
Boaz
next prev parent reply other threads:[~2008-01-03 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 7:00 [PATCH 0/2] sg_ring: Gentler scsi merge Rusty Russell
2008-01-03 8:50 ` [PATCH 1/3] scsi: Convert everyone to scsi_sglist and scsi_sg_count Rusty Russell
2008-01-03 8:54 ` [PATCH 2/3] usb_storage: usb_stor_bulk_transfer_sg cleanup Rusty Russell
2008-01-03 8:55 ` [PATCH 3/3] scsi: convert core to sg_ring Rusty Russell
2008-01-03 9:26 ` Boaz Harrosh [this message]
2008-01-04 3:28 ` [PATCH 1/3] scsi: Convert everyone to scsi_sglist and scsi_sg_count Rusty Russell
2008-01-03 9:42 ` [PATCH 0/2] sg_ring: Gentler scsi merge Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477CAA35.3020900@panasas.com \
--to=bharrosh@panasas.com \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.