All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: "Dong, Eddie" <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 1/3] Make virtio modules GPL
Date: Thu, 03 Jan 2008 09:13:15 -0600	[thread overview]
Message-ID: <477CFB8B.6060204@us.ibm.com> (raw)
In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A02976D62-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 3123 bytes --]

Dong, Eddie wrote:
> Curuious: should we consider it to be dual licensed from beginning?
>   

AFAIK, they are GPLv2+. I think Rusty was talking about dual licensing
the headers. He'll have to comment on that though.

Regards,

Anthony Liguori

> thx,eddie
>
>   
>> -----Original Message-----
>> From: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org 
>> [mailto:kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of 
>> Anthony Liguori
>> Sent: 2008年1月3日 5:02
>> To: virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
>> Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>> Subject: [kvm-devel] [PATCH 1/3] Make virtio modules GPL
>>
>> The virtio modules do not advertise themselves as GPL but rely 
>> on exported
>> GPL symbols.  This makes them unloadable as modules.
>>
>> This patch adds the appropriate MODULE_LICENSE().
>>
>> Signed-off: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>>
>> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
>> index 54a8017..8f6040d 100644
>> --- a/drivers/block/virtio_blk.c
>> +++ b/drivers/block/virtio_blk.c
>> @@ -8,6 +8,8 @@
>>
>> #define VIRTIO_MAX_SG	(3+MAX_PHYS_SEGMENTS)
>>
>> +MODULE_LICENSE("GPL");
>> +
>> static unsigned char virtblk_index = 'a';
>> struct virtio_blk
>> {
>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>> index ebe4b03..9789e68 100644
>> --- a/drivers/net/virtio_net.c
>> +++ b/drivers/net/virtio_net.c
>> @@ -28,6 +28,8 @@
>> static int napi_weight = 128;
>> module_param(napi_weight, int, 0444);
>>
>> +MODULE_LICENSE("GPL");
>> +
>> /* FIXME: MTU in config. */
>> #define MAX_PACKET_LEN (ETH_HLEN+ETH_DATA_LEN)
>>
>> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
>> index 646f716..6e27c08 100644
>> --- a/drivers/virtio/virtio.c
>> +++ b/drivers/virtio/virtio.c
>> @@ -2,6 +2,8 @@
>> #include <linux/spinlock.h>
>> #include <linux/virtio_config.h>
>>
>> +MODULE_LICENSE("GPL");
>> +
>> static ssize_t device_show(struct device *_d,
>> 			   struct device_attribute *attr, char *buf)
>> {
>> diff --git a/drivers/virtio/virtio_ring.c 
>> b/drivers/virtio/virtio_ring.c
>> index 951e4c7..15ee2fa 100644
>> --- a/drivers/virtio/virtio_ring.c
>> +++ b/drivers/virtio/virtio_ring.c
>> @@ -20,6 +20,8 @@
>> #include <linux/virtio_ring.h>
>> #include <linux/device.h>
>>
>> +MODULE_LICENSE("GPL");
>> +
>> #ifdef DEBUG
>> /* For development, we want to crash whenever the ring is screwed. */
>> #define BAD_RING(vq, fmt...)			\
>>
>> ---------------------------------------------------------------
>> ----------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2005.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________
>> kvm-devel mailing list
>> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>>
>>     



[-- Attachment #2: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

  parent reply	other threads:[~2008-01-03 15:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02 21:01 [PATCH 1/3] Make virtio modules GPL Anthony Liguori
2008-01-02 21:01 ` [PATCH 2/3] Make virtio_pci license be GPL2+ Anthony Liguori
     [not found] ` <1199307694277-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-01-02 21:01   ` [PATCH 3/3] Use Qumranet donated PCI vendor/device IDs Anthony Liguori
     [not found]     ` <11993076953191-git-send-email-aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-01-03  0:57       ` Rusty Russell
2008-01-03  0:57     ` Rusty Russell
2008-01-03  0:43   ` [PATCH 1/3] Make virtio modules GPL Dong, Eddie
     [not found]     ` <10EA09EFD8728347A513008B6B0DA77A02976D62-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2008-01-03 15:13       ` Anthony Liguori [this message]
2008-01-03 15:13     ` [kvm-devel] " Anthony Liguori
2008-01-24  1:04   ` Rusty Russell
2008-01-02 21:01 ` [PATCH 3/3] Use Qumranet donated PCI vendor/device IDs Anthony Liguori
2008-01-03  0:43 ` [kvm-devel] [PATCH 1/3] Make virtio modules GPL Dong, Eddie
2008-01-24  1:04 ` Rusty Russell
  -- strict thread matches above, loose matches on Subject: below --
2008-01-02 21:01 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=477CFB8B.6060204@us.ibm.com \
    --to=aliguori-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.