Re: [PATCH #upstream-fixes] sata_qstor: use hardreset instead of softreset

[Mark Lord <liml@rtr.ca>]

Tejun Heo wrote:
> During conversion to new EH, sata_qstor was accidentaly changed to use
> softreset, which is buggy on this chip, instead of hardreset.  This
> patch updates sata_qstor such that it uses hardreset again.
> 
> This fixes bugzilla bug 9631.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Mark Lord <mlord@pobox.com>
> ---
>  drivers/ata/sata_qstor.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/sata_qstor.c b/drivers/ata/sata_qstor.c
> index 2f1de6e..c68b241 100644
> --- a/drivers/ata/sata_qstor.c
> +++ b/drivers/ata/sata_qstor.c
> @@ -270,7 +270,7 @@ static int qs_scr_read(struct ata_port *ap, unsigned int sc_reg, u32 *val)
>  static void qs_error_handler(struct ata_port *ap)
>  {
>  	qs_enter_reg_mode(ap);
> -	ata_do_eh(ap, qs_prereset, ata_std_softreset, NULL,
> +	ata_do_eh(ap, qs_prereset, NULL, sata_std_hardreset,
>  		  ata_std_postreset);
>  }
>  

Ack.  This fixes a regression and should go out in 2.6.24.

And now we know that I'm not the only Linux user on the planet
with a QStor card -- there's at least one other out there!

Cheers