From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] /* inside comment in libfdt.h
Date: Thu, 03 Jan 2008 14:47:11 -0500 [thread overview]
Message-ID: <477D3BBF.9020301@ge.com> (raw)
In-Reply-To: <1199388486.15929.24.camel@ld0161-tx32>
Jon Loeliger wrote:
> On Wed, 2008-01-02 at 07:13, Jerry Van Baren wrote:
>
>> Yes, nested comments is something that should not be done and should be
>> fixed. This was inherited from the original code, although the current
>> version uses // for the embedded comment which avoids the issue (but
>> causes "no C++ comments" people to break out in rashes).
>>
>> <http://jdl.com/git_repos/?p=dtc.git;a=blob;f=libfdt/libfdt.h;h=ac0f5c3d1b41a1f6a8a5637a11d3ae4b9b6e6ed4;hb=3e516d961a45a2a410a9dc8f61fbdd62641b5ca0#l547>
>
> Woah, hey! That's me!
>
> Uh...
Stop. Take a deep breath. It really wasn't you, just had your
fingerprints because you touched it last. I referenced your repository
as the convenient/canonical repository for dtc/libfdt.
[snip]
> Oh man....
>
> OK. For the record, I'm all for only comments like this:
>
> /*
> *
> */
>
> Clearly lax, I'll start enforcing it on the DTC sources more.
>
> Sorry.
>
> jdl
FWIIW, the misdeed was the sample code embedded inside the comment had a
(sample) commented line "// add code here" which was done with a C++ //
comment so that it didn't run afoul of the C compiler's no nested
comments rule. A certain dignitary who breaks out in a rash when he
sees // comments made a "trivial" change to a /* */ comment, which then
caused the C compiler to throw a hissy fit because it now *was* a nested
comment.
All in all, a comedy of good intentions. No Code Was Harmed(R) in the
making of this patch sequence.
HTH,
gvb
(R)
<http://www.americanhumane.org/site/PageServer?pagename=faqs_film_end_credit>
P.S. :-D, but you knew that already.
next prev parent reply other threads:[~2008-01-03 19:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-02 12:46 [U-Boot-Users] /* inside comment in libfdt.h Matthias Fuchs
2008-01-02 13:13 ` Jerry Van Baren
2008-01-02 13:49 ` Matthias Fuchs
2008-01-03 19:28 ` Jon Loeliger
2008-01-03 19:35 ` Scott Wood
2008-01-03 19:47 ` Jerry Van Baren [this message]
2008-01-03 23:41 ` David Gibson
2008-01-04 10:24 ` Matthias Fuchs
2008-01-04 12:43 ` Jerry Van Baren
2008-01-04 16:22 ` Jon Loeliger
2008-01-02 15:01 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477D3BBF.9020301@ge.com \
--to=gerald.vanbaren@ge.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.