From: Eric Dumazet <dada1@cosmosbay.com>
To: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: [ICMP]: Avoid sparse warnings in net/ipv4/icmp.c
Date: Fri, 04 Jan 2008 06:24:20 +0100 [thread overview]
Message-ID: <477DC304.40508@cosmosbay.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
CHECK net/ipv4/icmp.c
net/ipv4/icmp.c:249:13: warning: context imbalance in 'icmp_xmit_unlock' -
unexpected unlock
net/ipv4/icmp.c:376:13: warning: context imbalance in 'icmp_reply' - different
lock contexts for basic block
net/ipv4/icmp.c:430:6: warning: context imbalance in 'icmp_send' - different
lock contexts for basic block
Solution is to declare icmp_xmit_unlock() as __inline__ (similar with
icmp_xmit_lock())
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
net/ipv4/icmp.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
[-- Attachment #2: icmp.patch --]
[-- Type: text/plain, Size: 335 bytes --]
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
index fc66c8a..01ce07b 100644
--- a/net/ipv4/icmp.c
+++ b/net/ipv4/icmp.c
@@ -246,7 +246,7 @@ static __inline__ int icmp_xmit_lock(void)
return 0;
}
-static void icmp_xmit_unlock(void)
+static __inline__ void icmp_xmit_unlock(void)
{
spin_unlock_bh(&icmp_sock->sk_lock.slock);
}
next reply other threads:[~2008-01-04 5:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 5:24 Eric Dumazet [this message]
2008-01-04 5:26 ` [ICMP]: Avoid sparse warnings in net/ipv4/icmp.c David Miller
2008-01-04 5:34 ` Eric Dumazet
2008-01-04 8:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477DC304.40508@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.