From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Mathieu Segaud <mathieu.segaud@regala.cx>
Cc: akpm@linux-foundation.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c
Date: Fri, 04 Jan 2008 14:41:51 +0100 [thread overview]
Message-ID: <477E379F.4000103@student.ltu.se> (raw)
In-Reply-To: <1199452896-20145-5-git-send-email-mathieu.segaud@regala.cx>
Mathieu Segaud wrote:
> Misc style fixes from checkpatch.pl
>
> Signed-off-by: Mathieu Segaud <mathieu.segaud@regala.cx>
> ---
> fs/ext3/ext3_jbd.c | 12 ++++++------
> fs/ext4/ext4_jbd2.c | 12 ++++++------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/fs/ext3/ext3_jbd.c b/fs/ext3/ext3_jbd.c
> index e1f91fd..6c96260 100644
> --- a/fs/ext3/ext3_jbd.c
> +++ b/fs/ext3/ext3_jbd.c
> @@ -9,7 +9,7 @@ int __ext3_journal_get_undo_access(const char *where, handle_t *handle,
> {
> int err = journal_get_undo_access(handle, bh);
> if (err)
> - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
>
> @@ -18,7 +18,7 @@ int __ext3_journal_get_write_access(const char *where, handle_t *handle,
> {
> int err = journal_get_write_access(handle, bh);
> if (err)
> - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
>
> @@ -27,7 +27,7 @@ int __ext3_journal_forget(const char *where, handle_t *handle,
> {
> int err = journal_forget(handle, bh);
> if (err)
> - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
>
> @@ -36,7 +36,7 @@ int __ext3_journal_revoke(const char *where, handle_t *handle,
> {
> int err = journal_revoke(handle, blocknr, bh);
> if (err)
> - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
>
> @@ -45,7 +45,7 @@ int __ext3_journal_get_create_access(const char *where,
> {
> int err = journal_get_create_access(handle, bh);
> if (err)
> - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
>
> @@ -54,6 +54,6 @@ int __ext3_journal_dirty_metadata(const char *where,
> {
> int err = journal_dirty_metadata(handle, bh);
> if (err)
> - ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext3_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
> diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c
> index d6afe4e..2256c43 100644
> --- a/fs/ext4/ext4_jbd2.c
> +++ b/fs/ext4/ext4_jbd2.c
> @@ -9,7 +9,7 @@ int __ext4_journal_get_undo_access(const char *where, handle_t *handle,
> {
> int err = jbd2_journal_get_undo_access(handle, bh);
> if (err)
> - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
>
> @@ -18,7 +18,7 @@ int __ext4_journal_get_write_access(const char *where, handle_t *handle,
> {
> int err = jbd2_journal_get_write_access(handle, bh);
> if (err)
> - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
>
> @@ -27,7 +27,7 @@ int __ext4_journal_forget(const char *where, handle_t *handle,
> {
> int err = jbd2_journal_forget(handle, bh);
> if (err)
> - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
>
> @@ -36,7 +36,7 @@ int __ext4_journal_revoke(const char *where, handle_t *handle,
> {
> int err = jbd2_journal_revoke(handle, blocknr, bh);
> if (err)
> - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
>
> @@ -45,7 +45,7 @@ int __ext4_journal_get_create_access(const char *where,
> {
> int err = jbd2_journal_get_create_access(handle, bh);
> if (err)
> - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
>
> @@ -54,6 +54,6 @@ int __ext4_journal_dirty_metadata(const char *where,
> {
> int err = jbd2_journal_dirty_metadata(handle, bh);
> if (err)
> - ext4_journal_abort_handle(where, __FUNCTION__, bh, handle,err);
> + ext4_journal_abort_handle(where, __FUNCTION__, bh, handle, err);
> return err;
> }
>
Hi Mathieu
What about changing the __FUNCTION__ to __func__, while you are at it?
Richard Knutsson
next prev parent reply other threads:[~2008-01-04 13:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 13:21 [PATCH] [Coding Style]: misc fixes for fs/ext{3,4}/acl.{c,h} from checkpatch.pl Mathieu Segaud
2008-01-04 13:21 ` [PATCH] [Coding Style]: fs/ext{3,4}/balloc.c Mathieu Segaud
2008-01-04 13:21 ` [PATCH] [Coding Style]: fs/ext{3,4}/bitmap.c Mathieu Segaud
2008-01-04 13:21 ` [PATCH] [Coding Style]: fs/ext{3,4}/dir.c Mathieu Segaud
2008-01-04 13:21 ` [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c Mathieu Segaud
2008-01-04 13:41 ` Richard Knutsson [this message]
2008-01-04 13:47 ` Mathieu SEGAUD
2008-01-05 4:12 ` Andreas Dilger
2008-01-05 4:47 ` Dmitri Vorobiev
2008-01-05 4:48 ` Dmitri Vorobiev
2008-01-05 5:18 ` Al Viro
2008-01-10 21:03 ` Roel Kluin
2008-01-11 3:09 ` Peter Stuge
2008-01-11 3:09 ` Peter Stuge
2008-01-11 3:42 ` Paul Mundt
2008-01-11 3:42 ` Paul Mundt
2008-01-11 3:46 ` Peter Stuge
2008-01-11 3:46 ` Peter Stuge
2008-01-11 9:45 ` Roel Kluin
2008-01-11 9:45 ` Roel Kluin
2008-01-11 10:29 ` Paul Mundt
2008-01-11 11:04 ` Roel Kluin
2008-01-11 11:04 ` Roel Kluin
2008-01-11 11:23 ` Paul Mundt
2008-01-11 12:27 ` Roel Kluin
2008-01-11 12:27 ` Roel Kluin
2008-01-04 13:44 ` [PATCH] [Coding Style]: misc fixes for fs/ext{3,4}/acl.{c,h} from checkpatch.pl Theodore Tso
2008-01-04 13:49 ` Mathieu SEGAUD
2008-01-04 13:56 ` Theodore Tso
2008-01-04 16:30 ` Andi Kleen
2008-01-04 19:01 ` Theodore Tso
2008-01-04 19:41 ` Andi Kleen
2008-01-04 20:01 ` Cyrill Gorcunov
2008-01-04 20:03 ` Paolo Ciarrocchi
2008-01-04 22:33 ` Andi Kleen
2008-01-05 0:12 ` Paolo Ciarrocchi
2008-01-05 0:39 ` Theodore Tso
2008-01-05 21:24 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477E379F.4000103@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.segaud@regala.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.