[PATCH] xentrace bug fix

[PATCH] xentrace bug fix

[Su, Disheng]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

In latest xen-unstable, result of xentrace_format is wrong, because the
data format of hvmtrace is changed.

Signed-off-by: Disheng Su <disheng.su@intel.com>

[-- Attachment #2: xentrace.patch --]
[-- Type: application/octet-stream, Size: 2407 bytes --]

diff -r ffeaf11905ed tools/xentrace/formats
--- a/tools/xentrace/formats	Thu Dec 27 02:26:08 2007 +0800
+++ b/tools/xentrace/formats	Thu Dec 27 02:43:23 2007 +0800
@@ -19,8 +19,8 @@ 0x0002f00d  CPU%(cpu)d  %(tsc)d (+%(relt
 0x0002f00d  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  dom_timer_fn
 
 0x00081001  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  VMENTRY     [ dom:vcpu = 0x%(1)08x ]
-0x00081002  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  VMEXIT      [ dom:vcpu = 0x%(1)08x, rIP  = 0x%(2)08x, exitcode = 0x%(3)08x ]
-0x00082001  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  PF_XEN      [ dom:vcpu = 0x%(1)08x, virt = 0x%(2)08x, errorcode = 0x%(3)02x ]
+0x00081002  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  VMEXIT      [ dom:vcpu = 0x%(1)08x, exitcode = 0x%(2)08x, rIP  = 0x%(3)08x ]
+0x00082001  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  PF_XEN      [ dom:vcpu = 0x%(1)08x, errorcode = 0x%(2)02x, virt = 0x%(3)08x ]
 0x00082002  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  PF_INJECT   [ dom:vcpu = 0x%(1)08x, virt = 0x%(2)08x, errorcode = 0x%(3)02x ]
 0x00082003  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  INJ_EXC     [ dom:vcpu = 0x%(1)08x, vector = 0x%(2)02x, errorcode = 0x%(3)04x ]
 0x00082004  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  INJ_VIRQ    [ dom:vcpu = 0x%(1)08x, vector = 0x%(2)02x, fake = %(3)d ]
@@ -45,4 +45,4 @@ 0x00082017  CPU%(cpu)d  %(tsc)d (+%(relt
 0x00082017  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  MMIO_ASSIST [ dom:vcpu = 0x%(1)08x, data = 0x%(2)04x ]
 0x00082018  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  CLTS        [ dom:vcpu = 0x%(1)08x ]
 0x00082019  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  LMSW        [ dom:vcpu = 0x%(1)08x, value = 0x%(2)08x ]
-0x00082020  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  PF_XEN64    [ dom:vcpu = 0x%(1)08x, virt = 0x%(2)08x, errorcode = 0x%(3)02x ]
+0x00082020  CPU%(cpu)d  %(tsc)d (+%(reltsc)8d)  PF_XEN64    [ dom:vcpu = 0x%(1)08x, errorcode = 0x%(2)02x, virt = 0x%(3)08x ]
diff -r ffeaf11905ed tools/xentrace/xentrace_format
--- a/tools/xentrace/xentrace_format	Thu Dec 27 02:26:08 2007 +0800
+++ b/tools/xentrace/xentrace_format	Thu Dec 27 02:30:16 2007 +0800
@@ -134,7 +134,7 @@ while not interrupted:
             line = sys.stdin.read(struct.calcsize(D1REC))
             if not line:
                 break
-            (d1) = struct.unpack(D1REC, line)
+            d1 = struct.unpack(D1REC, line)[0]
         if n_data == 2:
             line = sys.stdin.read(struct.calcsize(D2REC))
             if not line:

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

RE: [PATCH] xentrace bug fix

[Dan Magenheimer]

Should tools/xentrace/formats be installed by the Makefile with "make install"?

If so, to what directory?  And what filename? ("formats" is a bit too generic)

I propose "/etc/xen/xentrace_format.defs"   Anybody disagree?

(And wherever it goes, the location should be mentioned in the man page.)

> -----Original Message-----
> From: xen-devel-bounces@lists.xensource.com
> [mailto:xen-devel-bounces@lists.xensource.com]On Behalf Of Su, Disheng
> Sent: Friday, December 28, 2007 12:45 AM
> To: xen-devel@lists.xensource.com
> Subject: [Xen-devel] [PATCH] xentrace bug fix
> 
> 
> In latest xen-unstable, result of xentrace_format is wrong, 
> because the
> data format of hvmtrace is changed.
> 
> Signed-off-by: Disheng Su <disheng.su@intel.com>
> 
>

Re: [PATCH] xentrace bug fix

[Mark Williamson]

> Should tools/xentrace/formats be installed by the Makefile with "make
> install"?
>
> If so, to what directory?  And what filename? ("formats" is a bit too
> generic)
>
> I propose "/etc/xen/xentrace_format.defs"   Anybody disagree?

I think that'd be sensible; and make xentrace_format look there by default.

Cheers,
Mark

> (And wherever it goes, the location should be mentioned in the man page.)
>
> > -----Original Message-----
> > From: xen-devel-bounces@lists.xensource.com
> > [mailto:xen-devel-bounces@lists.xensource.com]On Behalf Of Su, Disheng
> > Sent: Friday, December 28, 2007 12:45 AM
> > To: xen-devel@lists.xensource.com
> > Subject: [Xen-devel] [PATCH] xentrace bug fix
> >
> >
> > In latest xen-unstable, result of xentrace_format is wrong,
> > because the
> > data format of hvmtrace is changed.
> >
> > Signed-off-by: Disheng Su <disheng.su@intel.com>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel



-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

Re: [PATCH] xentrace bug fix

[John Levon]

On Fri, Jan 04, 2008 at 05:45:06PM +0000, Mark Williamson wrote:

> > Should tools/xentrace/formats be installed by the Makefile with "make
> > install"?
> >
> > If so, to what directory?  And what filename? ("formats" is a bit too
> > generic)
> >
> > I propose "/etc/xen/xentrace_format.defs"   Anybody disagree?
> 
> I think that'd be sensible; and make xentrace_format look there by default.

Is the file editable by normal users? I would have thought not?

regards
john

Re: [PATCH] xentrace bug fix

[Mark Williamson]

On Saturday 05 January 2008, John Levon wrote:
> On Fri, Jan 04, 2008 at 05:45:06PM +0000, Mark Williamson wrote:
> > > Should tools/xentrace/formats be installed by the Makefile with "make
> > > install"?
> > >
> > > If so, to what directory?  And what filename? ("formats" is a bit too
> > > generic)
> > >
> > > I propose "/etc/xen/xentrace_format.defs"   Anybody disagree?
> >
> > I think that'd be sensible; and make xentrace_format look there by
> > default.
>
> Is the file editable by normal users? I would have thought not?
>

Right now, AFAIK it's not actually installed since it's a developer tool and 
it's assumed you have a copy of the repository hanging around somewhere to 
get the format definitions from...

Having a default path in /etc/xen/xentrace_format.defs would enable 
xentrace_format to translate xentrace output "out of the box".  If that route 
were taken, then xentrace_format should still be able to take a format file 
as an argument to override the default.

Does that sound OK?

Cheers,
Mark

-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

Re: [PATCH] xentrace bug fix

[Rob Gardner]

John Levon wrote:
> On Fri, Jan 04, 2008 at 05:45:06PM +0000, Mark Williamson wrote:
>
>   
>>> Should tools/xentrace/formats be installed by the Makefile with "make
>>> install"?
>>>
>>> If so, to what directory?  And what filename? ("formats" is a bit too
>>> generic)
>>>
>>> I propose "/etc/xen/xentrace_format.defs"   Anybody disagree?
>>>       
>> I think that'd be sensible; and make xentrace_format look there by default.
>>     
>
> Is the file editable by normal users? I would have thought not?
>   
Probably if a user has permission to run xentrace then he will also be 
able to edit the formats.

Rob