From: Easwar Hariharan <eahariha@linux.microsoft.com>
To: Praveen Kumar <kumarpraveen@linux.microsoft.com>,
lkp@intel.com, "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
"open list:Hyper-V/Azure CORE AND DRIVERS"
<linux-hyperv@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: eahariha@linux.microsoft.com, Naman Jain <namjain@linux.microsoft.com>
Subject: Re: [PATCH 2/2] drivers: hv: Convert open-coded timeouts to secs_to_jiffies()
Date: Wed, 23 Oct 2024 10:35:11 -0700 [thread overview]
Message-ID: <477f31d9-b696-479e-9b5b-7bfbbeaa6c47@linux.microsoft.com> (raw)
In-Reply-To: <288243cd-51d9-4c76-8337-298e9bf339d5@linux.microsoft.com>
On 10/22/2024 10:36 PM, Praveen Kumar wrote:
> On 23-10-2024 00:23, Easwar Hariharan wrote:
>> We have several places where timeouts are open-coded as N (seconds) * HZ,
>> but best practice is to use the utility functions from jiffies.h. Convert
>> the timeouts to be compliant. This doesn't fix any bugs, it's a simple code
>> improvement.
>>
>> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
>
> I think this is second version of this patch series?
>
> Please make sure, you update the patch version details and document the changes done in the current version.
>
This is the first non-RFC version, but yes, I should have documented the
changes and linked the RFC version.
Thanks,
Easwar
next prev parent reply other threads:[~2024-10-23 17:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 18:53 [PATCH 1/2] jiffies: Define secs_to_jiffies() Easwar Hariharan
2024-10-22 18:53 ` [PATCH 2/2] drivers: hv: Convert open-coded timeouts to secs_to_jiffies() Easwar Hariharan
2024-10-22 22:58 ` Easwar Hariharan
2024-10-23 5:36 ` Praveen Kumar
2024-10-23 17:35 ` Easwar Hariharan [this message]
2024-10-22 22:58 ` [PATCH 1/2] jiffies: Define secs_to_jiffies() Easwar Hariharan
2024-10-23 12:36 ` Anna-Maria Behnsen
2024-10-23 18:02 ` Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477f31d9-b696-479e-9b5b-7bfbbeaa6c47@linux.microsoft.com \
--to=eahariha@linux.microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kumarpraveen@linux.microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=namjain@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.