From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAX34-0007N8-UN for ath10k@lists.infradead.org; Wed, 18 Sep 2019 10:19:00 +0000 MIME-Version: 1.0 Date: Wed, 18 Sep 2019 18:18:56 +0800 From: Yibo Zhao Subject: Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode In-Reply-To: <871rwdj4ez.fsf@toke.dk> References: <1568639388-27291-1-git-send-email-yiboz@codeaurora.org> <1568639388-27291-3-git-send-email-yiboz@codeaurora.org> <6684ceecde399edeb31c594f889a403440c78142.camel@sipsolutions.net> <8e4cd872d082c6bce598c87411a2125f@codeaurora.org> <87lfumiq3w.fsf@toke.dk> <595c99a36c4f3e3eb131894d85c09746@codeaurora.org> <871rwdj4ez.fsf@toke.dk> Message-ID: <4780268b967c128a42396c39d697e67e@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless-owner@vger.kernel.org, Johannes Berg , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gMjAxOS0wOS0xOCAxODoxNiwgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+IFlp Ym8gWmhhbyA8eWlib3pAY29kZWF1cm9yYS5vcmc+IHdyaXRlczoKPiAKPj4gT24gMjAxOS0wOS0x OCAwNToxMiwgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+Pj4gWWlibyBaaGFvIDx5 aWJvekBjb2RlYXVyb3JhLm9yZz4gd3JpdGVzOgo+Pj4gCj4+Pj4gT24gMjAxOS0wOS0xNiAyMzoy NywgSm9oYW5uZXMgQmVyZyB3cm90ZToKPj4+Pj4gV2l0aG91dCByZWFsbHkgbG9va2luZyBhdCB0 aGUgY29kZSAtCj4+Pj4+IAo+Pj4+Pj4gSWYgc3RhdGlvbiBpcyBpbmVsaWdpYmxlIGZvciB0cmFu c21pc3Npb24gaW4KPj4+Pj4+IGllZWU4MDIxMV90eHFfbWF5X3RyYW5zbWl0KCksCj4+Pj4+PiBu byBwYWNrZXQgd2lsbCBiZSBkZWxpdmVyZWQgdG8gRlcuIER1cmluZyB0aGUgdGVzdHMgaW4gcHVz aC1wdWxsCj4+Pj4+PiBtb2RlCj4+Pj4+PiB3aXRoCj4+Pj4+PiBtYW55IGNsaWVudHMsIGFmdGVy IHNldmVyYWwgc2Vjb25kcywgbm90IGEgc2luZ2xlIHN0YXRpb24gaXMgYW4KPj4+Pj4+IGVsaWdp YmxlCj4+Pj4+PiBjYW5kaWRhdGUgZm9yIHRyYW5zbWlzc2lvbiBzaW5jZSBnbG9iYWwgdGltZSBp cyBzbWFsbGVyIHRoYW4gYWxsIAo+Pj4+Pj4gdGhlCj4+Pj4+PiBzdGF0aW9uJ3MgdmlydHVhbCBh aXJ0aW1lLiBBcyBhIGNvbnNlcXVlbmNlLCB0aGUgVHggaGFzIGJlZW4gCj4+Pj4+PiBibG9ja2Vk Cj4+Pj4+PiBhbmQKPj4+Pj4+IHRocm91Z2hwdXQgaXMgcXVpdGUgbG93Lgo+Pj4+PiAKPj4+Pj4g WW91IHNob3VsZCByZXdyaXRlIHRoaXMgdG8gYmUsIGVybSwgYSBiaXQgbW9yZSB1bmRlcnN0YW5k YWJsZSBpbgo+Pj4+PiBtYWM4MDIxMSBjb250ZXh0LiBJIGFzc3VtZSB5b3UncmUgc3BlYWtpbmcg KG1vc3RseT8pIGFib3V0IGF0aDEwaywKPj4+Pj4gYnV0Cj4+Pj4+IEkKPj4+Pj4gaGF2ZSB2ZXJ5 IGxpdHRsZSBjb250ZXh0IHRoZXJlLiAicHVzaCBwdWxsIG1vZGUiPyAiZmlybXdhcmUiPyBUaGVz ZQo+Pj4+PiB0aGluZ3MgYXJlIG5vdCBzb21ldGhpbmcgbWFjODAyMTEga25vd3MgYWJvdXQuCj4+ Pj4gSGkgSm9oYW5uZXMsCj4+Pj4gCj4+Pj4gVGhhbmtzIGZvciB5b3VyIGtpbmRseSByZW1pbmRl ci4gV2lsbCByZXdyaXRlIHRoZSBjb21taXQgbG9nLgo+Pj4+IAo+Pj4+PiAKPj4+Pj4+IENvLWRl dmVsb3BlZC1ieTogWWlibyBaaGFvIDx5aWJvekBjb2RlYXVyb3JhLm9yZz4KPj4+Pj4gCj4+Pj4+ IFRoYXQgYWxzbyBzZWVtcyB3cm9uZywgc2hvdWxkIGJlIFRva2UgSSBndWVzcywgdW5sZXNzIHlv dSBpbnRlbmRlZAo+Pj4+PiBmb3IKPj4+Pj4gYQo+Pj4+PiBGcm9tOiBUb2tlIHRvIGJlIHByZXNl bnQ/Cj4+Pj4gRG8geW91IG1lYW4gaXQgc2hvdWxkIGJlIHNvbWV0aGluZyBsaWtlOgo+Pj4+IAo+ Pj4+IENvLWRldmVsb3BlZC1ieTogVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHRva2Uu ZGs+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogWWlibyBaaGFvIDx5aWJvekBjb2RlYXVyb3JhLm9yZz4K Pj4+PiBTaWduZWQtb2ZmLWJ5OiBUb2tlIEjDuGlsYW5kLUrDuHJnZW5zZW4gPHRva2VAdG9rZS5k az4KPj4+PiAKPj4+PiBBbSBJIHVuZGVyc3RhbmRpbmcgcmlnaHQ/Cj4+PiAKPj4+IEkgdGhpbmsg dGhlIHJpZ2h0IHRoaW5nIGhlcmUsIGFzIHdpdGggdGhlIHByZXZpb3VzIHBhdGNoLCBpcyB0byBq dXN0Cj4+PiBkcm9wIG15IHNpZ24tb2ZmOyB5b3UncmUgd3JpdGluZyB0aGlzIHBhdGNoLCBhbmQg SSdsbCBhZGQgYWNrL3Jldmlld3MKPj4+IGFzCj4+PiBhcHByb3ByaWF0ZS4gQW5kIGluIHRoYXQg Y2FzZSwgd2VsbCwgbm8gbmVlZCB0byBoYXZlIGNvLWRldmVsb3BlZC1ieQo+Pj4geW91cnNlbGYg d2hlbiB5b3VyIG5hbWUgaXMgb24gdGhlIHBhdGNoIGFzIGF1dGhvciA6KQo+Pj4gCj4+PiAtVG9r ZQo+PiBTb3JyeSwgSSB0aGluayBJIGhhdmUgbWlzc2VkIGNoZWNraW5nIHlvdXIgcmVwbHksIHBs ZWFzZSBpZ25vcmUgdGhlCj4+IHdyb25nIHNpZ25lZC1vZmYgaW4gUEFUQ0gtVjIuCj4gCj4gV2hp bGUgeW91J3JlIHJlLXNwaW5uaW5nLCBjb3VsZCB5b3UgcGxlYXNlIGFkZCBhIGNoYW5nZWxvZyBm b3IgdGhlCj4gY2hhbmdlcyB5b3UgbWFrZT8gTWFrZXMgaXQgZWFzaWVyIHRvIGtlZXAgdHJhY2sg OikKPiAKPiBZb3UgY2FuIGFkZCBhIGNvdmVyLWxldHRlciB3aXRoIGEgZnVsbCBjaGFuZ2Vsb2cg aW5zdGVhZCBvZiBoYXZpbmcgYQo+IHNlcGFyYXRlIGNoYW5nZWxvZyBmb3IgZWFjaCBwYXRjaDsg dGhhdCdzIHdoYXQgSSB1c3VhbGx5IGRvLi4uCj4gCj4gLVRva2UKU3VyZSwgdGhhbmtzLgotLSAK WWlibwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRo MTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10EFCC4CEC9 for ; Wed, 18 Sep 2019 10:19:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7CF3218AF for ; Wed, 18 Sep 2019 10:19:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="kDIX2fP3"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="M9KYs/TR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729559AbfIRKTA (ORCPT ); Wed, 18 Sep 2019 06:19:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52256 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729482AbfIRKTA (ORCPT ); Wed, 18 Sep 2019 06:19:00 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A18C260741; Wed, 18 Sep 2019 10:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568801938; bh=x5KQoxkKPdpw3obd8l7+AXrpmpoqBbu12IbMaDiZPjw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kDIX2fP3OD9fVQeaZlsH7pAx1wZaPRjyn8RMGVWL7wrzcFiG5SDtXLIZJP32+UjZ0 wKOppnRVydI1VxUbswhlwytdut/uHs+rAD2hVuCc4sPzMvbUbMaA+HqLkEbg65aCNe NSA9eeMs5IFwtYB3OUgvBztkxbfLhWJsS5WlVB4Y= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id ACA066050D; Wed, 18 Sep 2019 10:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568801937; bh=x5KQoxkKPdpw3obd8l7+AXrpmpoqBbu12IbMaDiZPjw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M9KYs/TR8ntrF+sR1H9IRyfuy4+KWN0+kh2Q3uqRFFi3+Jd6KVYgT1uCSagtzhzLq oI93gUUZbzYVM6kdh0lVk3ybnJj7rgYeJg2kT4OtL0QflhTf1fZ1Tq7UlkIm01LQ3W LqegDn8x2z3addyZbtiwuBgicAgiJAzravYptMFk= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 18 Sep 2019 18:18:56 +0800 From: Yibo Zhao To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Johannes Berg , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode In-Reply-To: <871rwdj4ez.fsf@toke.dk> References: <1568639388-27291-1-git-send-email-yiboz@codeaurora.org> <1568639388-27291-3-git-send-email-yiboz@codeaurora.org> <6684ceecde399edeb31c594f889a403440c78142.camel@sipsolutions.net> <8e4cd872d082c6bce598c87411a2125f@codeaurora.org> <87lfumiq3w.fsf@toke.dk> <595c99a36c4f3e3eb131894d85c09746@codeaurora.org> <871rwdj4ez.fsf@toke.dk> Message-ID: <4780268b967c128a42396c39d697e67e@codeaurora.org> X-Sender: yiboz@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-09-18 18:16, Toke Høiland-Jørgensen wrote: > Yibo Zhao writes: > >> On 2019-09-18 05:12, Toke Høiland-Jørgensen wrote: >>> Yibo Zhao writes: >>> >>>> On 2019-09-16 23:27, Johannes Berg wrote: >>>>> Without really looking at the code - >>>>> >>>>>> If station is ineligible for transmission in >>>>>> ieee80211_txq_may_transmit(), >>>>>> no packet will be delivered to FW. During the tests in push-pull >>>>>> mode >>>>>> with >>>>>> many clients, after several seconds, not a single station is an >>>>>> eligible >>>>>> candidate for transmission since global time is smaller than all >>>>>> the >>>>>> station's virtual airtime. As a consequence, the Tx has been >>>>>> blocked >>>>>> and >>>>>> throughput is quite low. >>>>> >>>>> You should rewrite this to be, erm, a bit more understandable in >>>>> mac80211 context. I assume you're speaking (mostly?) about ath10k, >>>>> but >>>>> I >>>>> have very little context there. "push pull mode"? "firmware"? These >>>>> things are not something mac80211 knows about. >>>> Hi Johannes, >>>> >>>> Thanks for your kindly reminder. Will rewrite the commit log. >>>> >>>>> >>>>>> Co-developed-by: Yibo Zhao >>>>> >>>>> That also seems wrong, should be Toke I guess, unless you intended >>>>> for >>>>> a >>>>> From: Toke to be present? >>>> Do you mean it should be something like: >>>> >>>> Co-developed-by: Toke Høiland-Jørgensen >>>> Signed-off-by: Yibo Zhao >>>> Signed-off-by: Toke Høiland-Jørgensen >>>> >>>> Am I understanding right? >>> >>> I think the right thing here, as with the previous patch, is to just >>> drop my sign-off; you're writing this patch, and I'll add ack/reviews >>> as >>> appropriate. And in that case, well, no need to have co-developed-by >>> yourself when your name is on the patch as author :) >>> >>> -Toke >> Sorry, I think I have missed checking your reply, please ignore the >> wrong signed-off in PATCH-V2. > > While you're re-spinning, could you please add a changelog for the > changes you make? Makes it easier to keep track :) > > You can add a cover-letter with a full changelog instead of having a > separate changelog for each patch; that's what I usually do... > > -Toke Sure, thanks. -- Yibo