From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
heiko.carstens@de.ibm.com, olof@lixom.net, mingo@elte.hu,
mpm@selenic.com
Subject: Re: [patch 1/5] Introduce __WARN()
Date: Sun, 06 Jan 2008 18:42:56 +0100 [thread overview]
Message-ID: <47811320.3040500@student.ltu.se> (raw)
In-Reply-To: <20080106091031.420c355d@laptopd505.fenrus.org>
Arjan van de Ven wrote:
> On Sun, 06 Jan 2008 17:09:44 +0100
> Richard Knutsson <ricknu-0@student.ltu.se> wrote:
>
>
>>>> (btw, wouldn't 'var != 0' actually be the proper semantic instead
>>>> of playing with '!'s?)
>>>>
>>>>
>>> no because var could be a pointer for example...
>>>
>>>
>> You mean because in that case it would be '!= NULL', do you? Sorry,
>> do not see your point here.
>>
>
> my point is that you don't know which one to use..
>
Sorry to be a bother, but why is that relevant? Except semantics, they
are the same, right? So what problem would it be if you send it a
pointer? The '!' uses the same "argument/reason" when given a pointer ;).
> But this isn't new discussion (nor something I'm changing at all); this has come
> up since way back in 2005 :)
> If you feel strongly of changing this, feel free to post a patch; for now I much
> rather leave things as they are right now.
>
Oh o-well, in such case I may come back and do a larger patching
someday. Just though since you were in the neighborhood...
Have a good evening
Richard Knutsson
next prev parent reply other threads:[~2008-01-06 17:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 3:07 [patch 0/5] enhance WARN_ON series Arjan van de Ven
2008-01-06 3:08 ` [patch 1/5] Introduce __WARN() Arjan van de Ven
2008-01-06 11:44 ` Richard Knutsson
2008-01-06 15:42 ` Arjan van de Ven
2008-01-06 16:09 ` Richard Knutsson
2008-01-06 17:10 ` Arjan van de Ven
2008-01-06 17:42 ` Richard Knutsson [this message]
2008-01-06 3:09 ` [patch 2/5] move WARN_ON() out of line Arjan van de Ven
2008-01-06 19:40 ` Olof Johansson
2008-01-06 3:10 ` [patch 3/5] Add the end-of-trace marker and the module list to WARN_ON() Arjan van de Ven
2008-01-06 10:04 ` David Woodhouse
2008-01-07 17:31 ` Valdis.Kletnieks
2008-01-06 3:11 ` [patch 4/5] bugh-remove-have_arch_bug--have_arch_warn Arjan van de Ven
2008-01-06 3:12 ` [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON Arjan van de Ven
2008-01-06 11:16 ` Benjamin Herrenschmidt
2008-01-06 14:46 ` Olof Johansson
2008-01-06 9:26 ` [patch 0/5] enhance WARN_ON series Ingo Molnar
2008-01-06 20:22 ` [PATCH] Add bug/warn marker to generic report_bug() Olof Johansson
2008-01-06 21:38 ` Arjan van de Ven
2008-01-07 1:22 ` Olof Johansson
2008-01-07 4:55 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47811320.3040500@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.