From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: Robert Hancock <hancockr@shaw.ca>, Jeff Garzik <jeff@garzik.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: [PATCH #upstream-fixes] sata_nv: disable ADMA mode by default
Date: Tue, 08 Jan 2008 00:35:10 +0900 [thread overview]
Message-ID: <478246AE.3020500@gmail.com> (raw)
In-Reply-To: <4782422C.8020202@rtr.ca>
There still are remaining issues with ADMA support. Disable it by
default and warn when enabling.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
Jeff, please hold off till Robert acks. Robert, what do you think?
drivers/ata/sata_nv.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
index ed5dc7c..27a0e34 100644
--- a/drivers/ata/sata_nv.c
+++ b/drivers/ata/sata_nv.c
@@ -639,7 +639,7 @@ MODULE_LICENSE("GPL");
MODULE_DEVICE_TABLE(pci, nv_pci_tbl);
MODULE_VERSION(DRV_VERSION);
-static int adma_enabled = 1;
+static int adma_enabled = 0;
static int swncq_enabled;
static void nv_adma_register_mode(struct ata_port *ap)
@@ -2396,6 +2396,9 @@ static int nv_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
/* determine type and allocate host */
if (type == CK804 && adma_enabled) {
dev_printk(KERN_NOTICE, &pdev->dev, "Using ADMA mode\n");
+ dev_printk(KERN_WARNING, &pdev->dev,
+ "WARNING: There are known problems with ADMA mode "
+ "which may lead to timeouts and/or system lock ups.\n");
type = ADMA;
}
next prev parent reply other threads:[~2008-01-07 15:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 9:25 disabling sata_nv ADMA for 2.6.24 Tejun Heo
2008-01-07 15:15 ` Mark Lord
2008-01-07 15:35 ` Tejun Heo [this message]
2008-01-10 5:58 ` [PATCH #upstream-fixes] sata_nv: disable ADMA mode by default Jeff Garzik
2008-01-10 6:29 ` Tejun Heo
2008-01-07 23:35 ` disabling sata_nv ADMA for 2.6.24 Robert Hancock
2008-01-07 23:56 ` Tejun Heo
2008-01-08 0:12 ` Robert Hancock
2008-01-08 1:01 ` Tejun Heo
2008-01-08 1:16 ` Tejun Heo
2008-01-08 2:29 ` Robert Hancock
2008-01-08 2:53 ` Tejun Heo
2008-01-08 2:55 ` Tejun Heo
2008-01-08 3:01 ` Robert Hancock
2008-01-08 3:08 ` Tejun Heo
2008-01-08 9:58 ` Tejun Heo
2008-01-08 14:40 ` Robert Hancock
2008-01-09 1:58 ` Tejun Heo
2008-01-09 2:00 ` Tejun Heo
2008-01-09 3:50 ` Robert Hancock
2008-01-09 5:09 ` Tejun Heo
2008-01-10 0:33 ` Robert Hancock
2008-01-10 6:59 ` Tejun Heo
2008-01-11 7:54 ` fixed a bug of adma in rhel4u5 with HDS7250SASUN500G Kuan Luo
2008-01-11 14:29 ` Robert Hancock
2008-01-11 21:57 ` David Milburn
2008-01-12 1:07 ` Robert Hancock
2008-01-14 3:08 ` Kuan Luo
2008-01-14 5:20 ` Robert Hancock
2008-01-14 6:23 ` Kuan Luo
2008-01-23 9:32 ` sata_nv and 2.6.24 (was Re: fixed a bug of adma in rhel4u5 with HDS7250SASUN500G.) Jeff Garzik
2008-01-23 14:44 ` Robert Hancock
2008-01-24 1:42 ` Jeff Garzik
2008-01-24 1:53 ` Robert Hancock
2008-01-24 0:43 ` fixed a bug of adma in rhel4u5 with HDS7250SASUN500G Robert Hancock
2008-01-24 3:20 ` Kuan Luo
2008-01-28 23:50 ` Robert Hancock
2008-01-29 2:48 ` Kuan Luo
2008-01-29 2:48 ` Kuan Luo
2008-01-29 4:59 ` Kuan Luo
2008-01-29 4:59 ` Kuan Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478246AE.3020500@gmail.com \
--to=htejun@gmail.com \
--cc=hancockr@shaw.ca \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.