All of lore.kernel.org
 help / color / mirror / Atom feed
From: Melvin Vermeeren <vermeeren@vermwa.re>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com, Milan Broz <mbroz@redhat.com>
Subject: Re: [dm-devel] Integrity discard/trim extremely slow on NVMe SSD storage (~10GiB/minute)
Date: Fri, 30 Apr 2021 21:26:23 +0200	[thread overview]
Message-ID: <4782666.JkfDSx4nLX@verm-r4e> (raw)
In-Reply-To: <alpine.LRH.2.02.2104261200140.27678@file01.intranet.prod.int.rdu2.redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 739 bytes --]

Hi Mikulas,

On Monday, 26 April 2021 18:02:12 CEST Mikulas Patocka wrote:
> Try this patch - it will avoid writing discard filler to metadata if it is
> already there. It won't help on the first discard, but it may help when
> discarding already discarded blocks.

I applied the patch and verified the patched kernel module is being used. 
Unfortunately there is no real difference while discarding. Presumably the 
drive is choking on the read requests alone? (As mentioned in other mail I 
contacted Seagate about this, it should be fixed in drive firmware.)

Still, the patch itself seems good and does avoid unnecessary writes, so it 
seems like a good thing to be merged in my opinion.

Thanks,

-- 
Melvin Vermeeren
Systems engineer

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 97 bytes --]

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

  reply	other threads:[~2021-05-03 11:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19 18:29 [dm-devel] Integrity discard/trim extremely slow on NVMe SSD storage (~10GiB/minute) Melvin Vermeeren
2021-04-26 15:33 ` Mikulas Patocka
2021-04-26 16:02   ` Mikulas Patocka
2021-04-30 19:26     ` Melvin Vermeeren [this message]
2021-05-12 19:26       ` Melvin Vermeeren
2021-04-30 19:23   ` Melvin Vermeeren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4782666.JkfDSx4nLX@verm-r4e \
    --to=vermeeren@vermwa.re \
    --cc=dm-devel@redhat.com \
    --cc=mbroz@redhat.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.