From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
Cc: kvm-devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Carlo Marcelo Arenas Belon
<carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
Subject: Re: [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit
Date: Mon, 07 Jan 2008 20:27:32 +0200 [thread overview]
Message-ID: <47826F14.6050504@qumranet.com> (raw)
In-Reply-To: <1199719004.23380.22.camel@frecb07144>
Laurent Vivier wrote:
> What I'm wondering now is: is it really useful to have "cache=off" and
> "snapshot=on" at the same time ?
>
No idea, but wouldn't want to rule it out.
> If not, the patch of Carlo is good, otherwise there is more
> modifications to do (in other parts of qemu).
>
If other modifications are needed, perhaps do them in the I/O submission
path (if unaligned and cache=off, force alignment). Since most of the
data will be aligned by the guest, the overhead will only be incurred by
the rare metadata accesses.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
prev parent reply other threads:[~2008-01-07 18:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 7:11 [PATCH] qemu: use statically allocate 512 byte buffer in the stack for sector in bdrv_commit Carlo Marcelo Arenas Belon
2008-01-07 9:27 ` Avi Kivity
[not found] ` <4781F08E.8060407-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-07 10:22 ` Laurent Vivier
2008-01-07 10:47 ` Avi Kivity
[not found] ` <4782034C.4000805-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-01-07 12:08 ` Laurent Vivier
2008-01-07 15:16 ` Laurent Vivier
2008-01-07 15:34 ` Javier Guerra
[not found] ` <90eb1dc70801070734l2062cac6r7a7bed1d6d3d2c0c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-01-07 15:45 ` Laurent Vivier
2008-01-07 16:03 ` Javier Guerra
[not found] ` <90eb1dc70801070803w1a863acs75677e707446f79a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-01-07 16:30 ` Laurent Vivier
2008-01-07 16:42 ` Javier Guerra
[not found] ` <90eb1dc70801070842g585cd92dr8a8a383e2f3274df-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-01-07 17:05 ` Laurent Vivier
2008-01-07 18:32 ` Avi Kivity
2008-01-07 18:29 ` Avi Kivity
2008-01-07 18:27 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47826F14.6050504@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=Laurent.Vivier-6ktuUTfB/bM@public.gmane.org \
--cc=carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.