All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, netdev@vger.kernel.org, viro@ZenIV.linux.org.uk
Subject: Re: [IPV4] ROUTE: Avoid sparse warnings
Date: Mon, 07 Jan 2008 21:46:45 +0100	[thread overview]
Message-ID: <47828FB5.1030303@cosmosbay.com> (raw)
In-Reply-To: <20080107203845.GA29803@gondor.apana.org.au>

Herbert Xu a écrit :
> On Mon, Jan 07, 2008 at 02:56:24PM +0100, Eric Dumazet wrote:
>> AFAIK, this patch reduces complexity and text size.
> 
> But if we had loads of empty hash buckets couldn't this potentially
> increase latency by disabling BH longer than before?

Well, we call rcu_read_unlock_bh()/rcu_read_lock_bh() for each bucket, empty 
or not, before and after patch, so we dont change latency.




  reply	other threads:[~2008-01-07 20:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-07 11:01 [IPV4] ROUTE: Avoid sparse warnings Eric Dumazet
2008-01-07 12:11 ` Herbert Xu
2008-01-07 13:56   ` Eric Dumazet
2008-01-07 20:38     ` Herbert Xu
2008-01-07 20:46       ` Eric Dumazet [this message]
2008-01-07 20:48         ` Herbert Xu
2008-01-08  6:54 ` David Miller
2008-01-08  7:53   ` Eric Dumazet
2008-01-08  9:34     ` David Miller
2008-01-08 12:59     ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47828FB5.1030303@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.