* [PATCH] x86_64: enable irq in default_idle
@ 2008-01-07 21:23 Hiroshi Shimamoto
2008-01-08 8:04 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Hiroshi Shimamoto @ 2008-01-07 21:23 UTC (permalink / raw)
To: mingo; +Cc: tglx, hpa, linux-kernel
Hi Ingo,
I think local_irq_enable() is missing in default_idle() on x86_64.
It's for recent x86 tree.
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Subject: [PATCH] x86_64: enable irq in default_idle
local_irq_enable() is missing after sched_clock_idle_wakeup_event().
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
arch/x86/kernel/process_64.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index c6ad1a0..93ce4f3 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -119,8 +119,8 @@ void default_idle(void)
t1 = ktime_get();
t1n = ktime_to_ns(t1);
sched_clock_idle_wakeup_event(t1n - t0n);
- } else
- local_irq_enable();
+ }
+ local_irq_enable();
current_thread_info()->status |= TS_POLLING;
}
--
1.5.3.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86_64: enable irq in default_idle
2008-01-07 21:23 [PATCH] x86_64: enable irq in default_idle Hiroshi Shimamoto
@ 2008-01-08 8:04 ` Ingo Molnar
2008-01-08 17:16 ` Hiroshi Shimamoto
0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2008-01-08 8:04 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: mingo, tglx, hpa, linux-kernel
* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> Hi Ingo,
>
> I think local_irq_enable() is missing in default_idle() on x86_64.
> It's for recent x86 tree.
>
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> Subject: [PATCH] x86_64: enable irq in default_idle
>
> local_irq_enable() is missing after sched_clock_idle_wakeup_event().
thanks Hiroshi, applied.
The effects of this bug should be increased latencies on 64-bit. Did you
notice these latencies, or did you find the bug in some other way (code
review)?
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86_64: enable irq in default_idle
2008-01-08 8:04 ` Ingo Molnar
@ 2008-01-08 17:16 ` Hiroshi Shimamoto
2008-01-08 22:12 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Hiroshi Shimamoto @ 2008-01-08 17:16 UTC (permalink / raw)
To: Ingo Molnar; +Cc: mingo, tglx, hpa, linux-kernel
Ingo Molnar wrote:
> * Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
>
>> Hi Ingo,
>>
>> I think local_irq_enable() is missing in default_idle() on x86_64.
>> It's for recent x86 tree.
>>
>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>> Subject: [PATCH] x86_64: enable irq in default_idle
>>
>> local_irq_enable() is missing after sched_clock_idle_wakeup_event().
>
> thanks Hiroshi, applied.
>
> The effects of this bug should be increased latencies on 64-bit. Did you
> notice these latencies, or did you find the bug in some other way (code
> review)?
I found this when I was comparing 32-bit and 64-bit source code
for x86 unification.
Thanks,
Hiroshi Shimamoto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86_64: enable irq in default_idle
2008-01-08 17:16 ` Hiroshi Shimamoto
@ 2008-01-08 22:12 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2008-01-08 22:12 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: mingo, tglx, hpa, linux-kernel
* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> >> local_irq_enable() is missing after
> >> sched_clock_idle_wakeup_event().
> >
> > thanks Hiroshi, applied.
> >
> > The effects of this bug should be increased latencies on 64-bit. Did
> > you notice these latencies, or did you find the bug in some other
> > way (code review)?
>
> I found this when I was comparing 32-bit and 64-bit source code for
> x86 unification.
cool :) Indeed even for other code, a number of times we got bugfixes
when unifying 32-bit and 64-bit files.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-01-08 22:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-07 21:23 [PATCH] x86_64: enable irq in default_idle Hiroshi Shimamoto
2008-01-08 8:04 ` Ingo Molnar
2008-01-08 17:16 ` Hiroshi Shimamoto
2008-01-08 22:12 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.