From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/3] sbc8548: Add basic support for Wind River SBC8548 as powerpc
Date: Mon, 07 Jan 2008 17:27:20 -0500 [thread overview]
Message-ID: <4782A748.5090502@windriver.com> (raw)
In-Reply-To: <E22DFF32-E85B-4A58-89D4-E447BEB8BA28@kernel.crashing.org>
Kumar Gala wrote:
>
> On Dec 21, 2007, at 12:43 AM, Paul Gortmaker wrote:
>
>> This adds the basic support for the Wind River SBC8548 board,
>> implemented
>> as powerpc. It closely follows the implementation of the MPC8548CDS.
>>
>>
[...]
>> +#ifdef CONFIG_PCI
>> +static int sbc8548_exclude_device(struct pci_controller *hose,
>> + u_char bus, u_char devfn)
>> +{
>> + if (bus == 0 && PCI_SLOT(devfn) == 0)
>> + return PCIBIOS_DEVICE_NOT_FOUND;
>> + else
>> + return PCIBIOS_SUCCESSFUL;
>> +}
>> +#endif
>
> see comment on the 8560 support, but I don't think you need to exclude
> the PHBs anymore. I've fixed this so we have a general quick for FSL
> PHBs.
>
Right. I wanted to also test on the 8548, since I can't really plug
anything
into my 8560, and on the 8548, the PCI behaviour is unaltered by
clobbering these. I'll send a patch removing it from both of the
sbc85xx boards in a bit.
Aside from this, and the 8548 dts-v1 conversion (already sent), I don't
think there were any other to-fix items for the sbc8548, so I won't
spam everyone with those 8548 patches again unless you need me to
rebase them or similar.
Thanks,
Paul.
>>
> - k
next prev parent reply other threads:[~2008-01-07 22:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 6:43 [PATCH 0/3] Powerpc support for SBC8548 board Paul Gortmaker
2007-12-21 6:43 ` [PATCH 1/3] sbc8548: Add basic support for Wind River SBC8548 as powerpc Paul Gortmaker
2007-12-21 6:43 ` Paul Gortmaker
2007-12-21 15:32 ` Kumar Gala
2008-01-07 22:27 ` Paul Gortmaker [this message]
2008-01-07 22:40 ` [PATCH] sbc85xx: remove PCI exclude device for sbc8548/sbc8560 Paul Gortmaker
2008-01-08 6:15 ` Kumar Gala
2007-12-21 6:43 ` [PATCH 2/3] sbc8548: Add device tree source for Wind River SBC8548 board Paul Gortmaker
2007-12-21 6:43 ` Paul Gortmaker
2007-12-21 15:33 ` Kumar Gala
2007-12-21 17:20 ` Paul Gortmaker
2007-12-22 2:05 ` David Gibson
2007-12-21 6:43 ` [PATCH 3/3] sbc8548: Add default .config file for Wind River SBC8548 Paul Gortmaker
2007-12-21 6:43 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4782A748.5090502@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.