From: David Howells <dhowells@redhat.com>
To: James Morris <jmorris@namei.org>
Cc: dhowells@redhat.com, a.beregalov@gmail.com,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] CRED: Further fix execve error handling
Date: Thu, 21 Aug 2008 13:43:23 +0100 [thread overview]
Message-ID: <4783.1219322603@redhat.com> (raw)
In-Reply-To: <alpine.LRH.1.10.0808210833080.8202@tundra.namei.org>
James Morris <jmorris@namei.org> wrote:
> How about moving the mutex_unlock() out of free_bprm() and into the
> calling code ?
Okay, I've sent you a patch to do this. Note that it only affects the error
handling case. In the case of a successful execution, install_exec_creds()
will release the mutex when it is safe to do so. This then permits
PTRACE_ATTACH to take place from that point. I could shift the unlock so that
it always happens in [compat_]do_execve() - do you think it's worth it? It
would mean that ptrace wouldn't be able to attach to a process that's still
under construction by the binfmt, which is probably reasonable.
David
prev parent reply other threads:[~2008-08-21 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 13:56 [PATCH] CRED: Further fix execve error handling David Howells
2008-08-20 14:21 ` Alexander Beregalov
2008-08-20 15:07 ` David Howells
2008-08-20 16:33 ` Alan Cox
2008-08-20 22:37 ` James Morris
2008-08-21 12:43 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4783.1219322603@redhat.com \
--to=dhowells@redhat.com \
--cc=a.beregalov@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.