From: Timur Tabi <timur@freescale.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v6] qe: add ability to upload QE firmware
Date: Tue, 08 Jan 2008 09:29:21 -0600 [thread overview]
Message-ID: <478396D1.2020806@freescale.com> (raw)
In-Reply-To: <20080108133747.f717e4b4.sfr@canb.auug.org.au>
Stephen Rothwell wrote:
> Why not:
> const u64 *iprop;
> int len;
>
> iprop = of_get_property(fs, "extended-modes", &len);
> if (iprop && (len == sizeof(u64))
> qe_firmware_info.extended_modes = *iprop;
Actually, I like my way better, because then I don't have to define 'len', and I
don't have to define two integer property variables one for u32 and one for u64.
Besides, now that I'm at version 6, I'd rather not post updates for minor
stylistic changes.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2008-01-08 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 22:15 [PATCH v6] qe: add ability to upload QE firmware Timur Tabi
2008-01-08 2:37 ` Stephen Rothwell
2008-01-08 15:26 ` Timur Tabi
2008-01-08 15:45 ` Josh Boyer
2008-01-08 15:29 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478396D1.2020806@freescale.com \
--to=timur@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.