Re: [RFC] Common header file for FC definitions

[James Smart <James.Smart@Emulex.Com>]

Christoph Hellwig wrote:
> On Tue, Jan 08, 2008 at 09:09:36AM +0100, Christof Schmitt wrote:
>> zfcp has a couple of definitions to describe the FC protocol. Grepping
>> through the complete source tree shows that e.g. the lpfc module makes
>> similar private definitions. It think that it would make sense to
>> introduce a global header file for FC related definitions that each FC
>> driver can use.
>>
>> The attached patch contains some definitons that i found in zfcp and
>> could be reused by other drivers.
>>
>> What do others think? Would this be useful?
> 
> This is a very good idea.  It might make more sense to have the more or
> less complete defintions for the fc protocol in the header.  Robert &
> folks have been working on a software fc stack part as the fcoe header
> so they might have one to contribute.

I Agree - A common header for standard FC definitions would be a good thing.

That said, we have to be a little lenient on when drivers convert over to
the standard headers as there's likely code change required.

-- james s