From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: enable irq in default_idle
Date: Tue, 08 Jan 2008 09:16:21 -0800 [thread overview]
Message-ID: <4783AFE5.6040102@ct.jp.nec.com> (raw)
In-Reply-To: <20080108080419.GD31838@elte.hu>
Ingo Molnar wrote:
> * Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
>
>> Hi Ingo,
>>
>> I think local_irq_enable() is missing in default_idle() on x86_64.
>> It's for recent x86 tree.
>>
>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>> Subject: [PATCH] x86_64: enable irq in default_idle
>>
>> local_irq_enable() is missing after sched_clock_idle_wakeup_event().
>
> thanks Hiroshi, applied.
>
> The effects of this bug should be increased latencies on 64-bit. Did you
> notice these latencies, or did you find the bug in some other way (code
> review)?
I found this when I was comparing 32-bit and 64-bit source code
for x86 unification.
Thanks,
Hiroshi Shimamoto
next prev parent reply other threads:[~2008-01-08 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 21:23 [PATCH] x86_64: enable irq in default_idle Hiroshi Shimamoto
2008-01-08 8:04 ` Ingo Molnar
2008-01-08 17:16 ` Hiroshi Shimamoto [this message]
2008-01-08 22:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4783AFE5.6040102@ct.jp.nec.com \
--to=h-shimamoto@ct.jp.nec.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.