From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Li Subject: vmcs_revision_id: do we care? Date: Tue, 08 Jan 2008 17:40:17 -0500 Message-ID: <4783FBD1.9020002@virtualiron.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Right now when xen finds out a SMP host has processors with different vmcs_revision_id, it considers it a bug. xen/arch/x86/hvm/vmx/vmcs.c:vmx_init_vmcs_config(): rdmsr(MSR_IA32_VMX_BASIC_MSR, vmx_msr_low, vmx_msr_high); if ( smp_processor_id() == 0 ) { vmcs_revision_id = vmx_msr_low; } else { BUG_ON(vmcs_revision_id != vmx_msr_low); } Does anyone know why are we doing this? Can we change that check into a warning message?