From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@novell.com>
Subject: Re: Is Xend versioned?
Date: Tue, 08 Jan 2008 19:06:04 -0700
Message-ID: <47842C0C.7070709@novell.com>
References: <47681A9B.3020402@novell.com>
	<200801041808.20614.mark.williamson@cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200801041808.20614.mark.williamson@cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Mark Williamson <mark.williamson@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Mark Williamson wrote:
>> When querying Xend for version this code is invoked in
>> tools/python/xen/xend/XendNode.py
>>
>>     def xen_version(self):
>>         info = self.xc.xeninfo()
>>
>>         try:
>>             from xen import VERSION
>>             info = {'Xen': '%(xen_major)d.%(xen_minor)d' % info,
>>                     'Xend': VERSION}
>>         except (ImportError, AttributeError):
>>             info = {'Xen': '%(xen_major)d.%(xen_minor)d' % info,
>>                     'Xend': '3.0.3'}
>>
>> I cannot find a xen module from which to import VERSION, resulting in
>> the hardcoded one.  I would cook up a patch if I understood how, or even
>> if, it should be versioned.
>>     
>
> You're right, I can't see what this is supposed to achieve...
>
> If you were to add:
>
> VERSION = "blah"
>
> to tools/python/xen/__init__.py
>
> then I imagine that would do the right thing.  As for whether it's necessary, 
> I'm not sure...  But presumably that code ought either to do something or to 
> be removed???
>   

I'm not sure there is any value in versioning xend itself.  Certainly
its interfaces (e.g. XenAPI) should be versioned but the whole daemon? 
I will spin a patch to remove it (or fix it) if there is consensus.

Regards,
Jim