All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Emelyanov <xemul@openvz.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH][VLAN] Merge tree equal tails in vlan_skb_recv
Date: Wed, 09 Jan 2008 11:15:35 +0300	[thread overview]
Message-ID: <478482A7.1040505@openvz.org> (raw)
In-Reply-To: <47591F9F.1020607@trash.net>

Hi, Patrick.

> Pavel Emelyanov wrote:
>> There are tree paths in it, that set the skb->proto and then
>> perform common receive manipulations (basically call netif_rx()).
>>
>> I think, that we can make this code flow easier to understand
>> by introducing the vlan_set_encap_proto() function (I hope the 
>> name is good) to setup the skb proto and merge the paths calling 
>> netif_rx() together.
>>
>> Surprisingly, but gcc detects this thing and merges these paths
>> by itself, so this patch doesn't make the vlan module smaller.
> 
> 
> I already have something similar queued, but your patch is a nice
> cleanup on top. I'll merge it into my tree and send it out after
> some testing, hopefully today.
> 

What are your plans about this patch? Should I resubmit this one?

Thanks,
Pavel

  reply	other threads:[~2008-01-09  8:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-07 10:22 [PATCH][VLAN] Merge tree equal tails in vlan_skb_recv Pavel Emelyanov
2007-12-07 10:25 ` Patrick McHardy
2008-01-09  8:15   ` Pavel Emelyanov [this message]
2008-01-09 18:42     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478482A7.1040505@openvz.org \
    --to=xemul@openvz.org \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.