Re: [PATCH] Simplified the invocation of command action in submodule

[Johannes Sixt <j.sixt@viscovery.net>]

imyousuf@gmail.com schrieb:
> @@ -16,6 +16,7 @@ update=
>  status=
>  quiet=
>  cached=
> +command=
>
>  #
>  # print stuff on stdout unless -q was specified
> @@ -293,20 +294,23 @@ modules_list()
>  	done
>  }
>
> +# command specifies the whole function name since
> +# one of theirs prefix is module not modules
>  while test $# != 0
>  do
>  	case "$1" in
>  	add)
>  		add=1
> +		command="module_$1"
>  		;;
>  	init)
> -		init=1
> +		command="modules_$1"
>  		;;
>  	update)
> -		update=1
> +		command="modules_$1"
>  		;;
>  	status)
> -		status=1
> +		command="modules_list"
>  		;;
>  	-q|--quiet)
>  		quiet=1
> @@ -320,7 +324,7 @@ do
>  		branch="$2"; shift
>  		;;
>  	--cached)
> -		cached=1
> +		command="modules_list"

Don't remove cached=1 because otherwise --cached is effectively ignored.

>  		;;
>  	--)
>  		break
> @@ -345,20 +349,8 @@ case "$add,$branch" in
>  	;;
>  esac
>
> -case "$add,$init,$update,$status,$cached" in
> -1,,,,)
> -	module_add "$@"
> -	;;
> -,1,,,)
> -	modules_init "$@"
> -	;;
> -,,1,,)
> -	modules_update "$@"
> -	;;
> -,,,*,*)
> -	modules_list "$@"
> -	;;
> -*)
> +if [ -z $command ]; then
>  	usage
> -	;;
> -esac
> +else
> +	"$command" "$@"
> +fi

- Previously 'git submodule' was equvalent to 'git submodule status', now
it is an error.

- Previously, passing --cached to add, init, or update was an error, now
it is not.

-- Hannes