All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andre Przywara" <andre.przywara@amd.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH 0/5] [ioemu]: fix ioemu warnings
Date: Wed, 09 Jan 2008 14:56:43 +0100	[thread overview]
Message-ID: <4784D29B.70705@amd.com> (raw)

Hi,

the following patches fix the warnings which appear when compiling ioemu 
on gcc4 (tested with gcc 4.1.2). As gcc4 is uncommon for pure QEMU, this 
hasn't been fixed there for a while. Keir stated that QEMU-related fixes 
should be upstream there, so I sent an adapted version of these patches 
to qemu-devel in December[1]. Eventually they got accepted there[2], so 
here is a ported version for ioemu.

I don't know if this is in vain, since a few days ago QEMU 0.9.1 has 
been released, which includes the patches (at least the 
QEMU-only-related). As I see from the commit-logs, ioemu gets updated to 
release versions of QEMU now and then, are there plans for doing this 
for 0.9.1?
And NO, I don't want to volunteer ;-)

The patches in detail:
1/5: fix wrong types:
gcc4 is more picky about the signedness of a pointer. Some variables 
were declared with an inappropriate signedness, this patch fixes this.
2/5: pointer casts:
Not all signedness pointer issues can be fixed by declaration, sometimes 
casts are necessary (mostly char* vs. uint8_t*).
3/5: qemu_{put,get} pointer signedness:
qemu_put* and qemu_get* use a unsigned pointer to the variables, some of 
them are declared signed, so this provokes a warning. Switching to call 
by value version of qemu_put, so the compiler handles this correctly.
4/5: fix declaration after statement:
ISO C90 forbids mixed declarations and code. ioemu is compiled with 
-Wdeclaration-after-statement, so this produces a warning. Moved the 
declerations to the beginning of a new block. This patch is not yet 
upstream in QEMU.
5/5: miscellaneous:
Some minor things (details in the patch)


Regards,
Andre.

[1]: http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00146.html
[2]: http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00417.html
      http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00420.html
      http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00448.html
      http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00452.html


-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

             reply	other threads:[~2008-01-09 13:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 13:56 Andre Przywara [this message]
2008-01-09 14:18 ` [PATCH 0/5] [ioemu]: fix ioemu warnings Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4784D29B.70705@amd.com \
    --to=andre.przywara@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.