All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Brindle <method@manicmethod.com>
To: Todd Miller <Tmiller@tresys.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>, selinux@tycho.nsa.gov
Subject: Re: [patch 7/7] Use -Werror
Date: Wed, 09 Jan 2008 09:24:02 -0500	[thread overview]
Message-ID: <4784D902.6000802@manicmethod.com> (raw)
In-Reply-To: <6FE441CD9F0C0C479F2D88F959B015880153F432@exchange.columbia.tresys.com>

Todd Miller wrote:
> Stephen Smalley wrote:
>   
>> On Mon, 2008-01-07 at 15:47 -0500, Todd C. Miller wrote:
>>     
>>> Stephen Smalley wrote:
>>>
>>>       
>>>> A bit overzealous though - some of them already had -Werror in
>>>> CFLAGS. Also need to make sure that -Werror gets included by make
>>>> DEBUG=1. 
>>>>         
>>> Updated patch without the duplicated -Werror and adds it for
>>> the DEBUG=1 cases.
>>>       
>> This breaks make pywrap in libselinux, or install-pywrap from top.
>>     
>
> I always forget that pywrap is not built by the default target.
> I'll commit a fix to filter out -Werror for pywrap.
>   

Also with DEBUG=1 there is another warning in newrole.c about a shadowed 
var.



--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2008-01-09 14:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-07 20:47 Re: [patch 7/7] Use -Werror Todd C. Miller
2008-01-08 12:59 ` Stephen Smalley
2008-01-09 13:09 ` Stephen Smalley
2008-01-09 14:19   ` Todd Miller
2008-01-09 14:24     ` Joshua Brindle [this message]
2008-01-09 15:33       ` Todd Miller
  -- strict thread matches above, loose matches on Subject: below --
2008-01-03 18:43 [patch 0/7] quiet gcc warnings tmiller
2008-01-03 18:43 ` [patch 7/7] Use -Werror tmiller
2008-01-07 18:06   ` Stephen Smalley
2008-01-07 18:30     ` Joshua Brindle
2008-01-07 18:50       ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4784D902.6000802@manicmethod.com \
    --to=method@manicmethod.com \
    --cc=Tmiller@tresys.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.