From: Anthony Liguori <aliguori@us.ibm.com>
To: dor.laor@qumranet.com
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] Increase the tx queue to 512 descriptors to fix performance problem.
Date: Wed, 09 Jan 2008 08:29:37 -0600 [thread overview]
Message-ID: <4784DA51.7080507@us.ibm.com> (raw)
In-Reply-To: <1199885016.4382.22.camel@localhost.localdomain>
Dor Laor wrote:
> Now that we have a host timer based tx wakeup it waits for 64
> packets or timeout before processing them.
> This might cause the guest to run out of tx buffers while the host
> holds them up.
>
There's a proper fix that Rusty added last night.
> This is a temporal solution to quickly bring back performance to 800mbps.
> But a better fix will soon be sent (its not the only problem).
>
How are you doing performance testing?
Regards,
Anthony Liguori
> Signed-off-by: Dor Laor <dor.laor@qumranet.com>
> ---
> qemu/hw/virtio-net.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu/hw/virtio-net.c b/qemu/hw/virtio-net.c
> index 777fe2c..3d07b65 100644
> --- a/qemu/hw/virtio-net.c
> +++ b/qemu/hw/virtio-net.c
> @@ -293,7 +293,7 @@ void *virtio_net_init(PCIBus *bus, NICInfo *nd, int devfn)
> n->vdev.update_config = virtio_net_update_config;
> n->vdev.get_features = virtio_net_get_features;
> n->rx_vq = virtio_add_queue(&n->vdev, 512, virtio_net_handle_rx);
> - n->tx_vq = virtio_add_queue(&n->vdev, 128, virtio_net_handle_tx);
> + n->tx_vq = virtio_add_queue(&n->vdev, 512, virtio_net_handle_tx);
> n->can_receive = 0;
> memcpy(n->mac, nd->macaddr, 6);
> n->vc = qemu_new_vlan_client(nd->vlan, virtio_net_receive,
>
next prev parent reply other threads:[~2008-01-09 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 13:23 [PATCH] Increase the tx queue to 512 descriptors to fix performance problem Dor Laor
2008-01-09 14:29 ` Anthony Liguori [this message]
2008-01-09 14:38 ` Dor Laor
[not found] ` <1199889527.4382.28.camel__11785.4029442698$1199889627$gmane$org-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-01-09 14:51 ` Anthony Liguori
2008-01-09 14:51 ` Anthony Liguori
[not found] ` <4784DA51.7080507-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-01-09 14:38 ` Dor Laor
-- strict thread matches above, loose matches on Subject: below --
2008-01-09 13:23 Dor Laor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4784DA51.7080507@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=dor.laor@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.