All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] libata and starting/stopping ATAPI floppy devices
Date: Thu, 10 Jan 2008 08:41:13 +0900	[thread overview]
Message-ID: <47855B99.3080302@gmail.com> (raw)
In-Reply-To: <200801091853.15601.linux@rainbow-software.org>

From: Ondrej Zary <linux@rainbow-software.org>

Prevent libata from starting/stopping non-ATA devices (like ATAPI floppy 
drives) as they don't seem to like it:

sd 1:0:1:0: [sdb] Starting disk
ata2.01: configured for PIO2
sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08
sd 1:0:1:0: [sdb] Sense Key : 0x2 [current]
sd 1:0:1:0: [sdb] ASC=0x3a ASCQ=0x0

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
Trimmed message body and reformatted such that it's script friendly.

 drivers/ata/libata-scsi.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.23-orig/drivers/ata/libata-scsi.c	2007-10-09 22:31:38.000000000 +0200
+++ linux-2.6.23-pentium/drivers/ata/libata-scsi.c	2008-01-05 15:50:16.000000000 +0100
@@ -802,7 +802,8 @@
 
 	blk_queue_max_phys_segments(sdev->request_queue, LIBATA_MAX_PRD);
 
-	sdev->manage_start_stop = 1;
+	if (dev->class == ATA_DEV_ATA)
+		sdev->manage_start_stop = 1;
 
 	if (dev)
 		ata_scsi_dev_config(sdev, dev);


  reply	other threads:[~2008-01-09 23:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-05 15:47 [PATCH] libata and starting/stopping ATAPI floppy devices Ondrej Zary
2008-01-09  2:41 ` Tejun Heo
2008-01-09 17:53   ` Ondrej Zary
2008-01-09 23:41     ` Tejun Heo [this message]
2008-01-10 22:21       ` Jeff Garzik
     [not found] <fa.BDdayWpk9nIIgpj7VGhVqIbyE8o@ifi.uio.no>
     [not found] ` <fa.muhws6klIiRnTK7h6EBkcjLsWKc@ifi.uio.no>
     [not found]   ` <fa.zyXilo1bU+hQgN72pXqBeBGBIMs@ifi.uio.no>
     [not found]     ` <fa.EGIY7yNytG7Ky56/SjBE7Jpn2PY@ifi.uio.no>
2008-01-10  1:05       ` Robert Hancock
2008-01-10 17:42         ` Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47855B99.3080302@gmail.com \
    --to=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.