Re: [PATCH #upstream-fixes] sata_nv: disable ADMA mode by default

[Tejun Heo <htejun@gmail.com>]

Hello, haven't fell asleep yet?

Jeff Garzik wrote:
> Tejun Heo wrote:
>> There still are remaining issues with ADMA support.  Disable it by
>> default and warn when enabling.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> ---
>> Jeff, please hold off till Robert acks.  Robert, what do you think?
>>
>>  drivers/ata/sata_nv.c |    5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> Don't worry, I won't "pull the trigger" immediately and without a lot of
> discussion.  (and please help keep nvidia cc'd on changes to sata_nv)
> 
> Current sleepless (thus discountable? :)) thoughts:
> 
> * definitely leaning towards adma=0 default.  if distros are disabling
> it, and upstream is not, that's a big hint :)

Well, here the distro is just 'me', so don't put too much weight on it.
 Maybe I'm just stressed out from all the bugs.

> * By switching to the tried-and-true legacy-IDE-like interface, adma=0
> seems to make a lot of problems go away.
> 
> * It is so late in 2.6.24-rc, it seems unlikely that we have enough time
> for testing such a major, fundamental behavior change in sata_nv, this
> late in the game.
>
> If it weren't for the time factor, I would be in favor of applying the
> patch and getting test results.

Everyone using suse using CK804 will end up testing adma=0 in a few
weeks.  Let's see how it explodes.

-- 
tejun