From: Scott Wood <scottwood@freescale.com>
To: hs@denx.de
Cc: linuxppc-dev@ozlabs.org, Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers
Date: Thu, 10 Jan 2008 11:27:08 -0600 [thread overview]
Message-ID: <4786556C.8040108@freescale.com> (raw)
In-Reply-To: <4785E014.4040709@denx.de>
Heiko Schocher wrote:
> diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
> index f2a4d39..f432a18 100644
> --- a/drivers/net/fs_enet/fs_enet-main.c
> +++ b/drivers/net/fs_enet/fs_enet-main.c
> @@ -810,6 +810,10 @@ static int fs_enet_open(struct net_device *dev)
> if (fep->fpi->use_napi)
> napi_enable(&fep->napi);
>
> + /* to initialize the fep->cur_rx,... */
> + /* not doing this, will cause a crash in fs_enet_rx_napi */
> + fs_init_bds(fep->ndev);
We should do this just before napi_enable() rather than just after, to
eliminate any chance of a race window.
Looks good otherwise.
-Scott
next prev parent reply other threads:[~2008-01-10 17:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 19:05 [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers Anton Vorontsov
2008-01-09 10:46 ` Sergej Stepanov
2008-01-09 10:46 ` Sergej Stepanov
2008-01-09 12:58 ` Heiko Schocher
2008-01-09 18:20 ` Scott Wood
2008-01-10 8:14 ` Heiko Schocher
2008-01-10 9:06 ` Heiko Schocher
2008-01-10 17:27 ` Scott Wood [this message]
2008-01-10 18:41 ` Heiko Schocher
2008-01-11 16:01 ` Sergej Stepanov
2008-01-12 22:45 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2008-01-09 20:10 Matvejchikov Ilya
2008-01-09 20:10 ` Matvejchikov Ilya
2008-01-09 20:14 Matvejchikov Ilya
2008-01-09 20:20 Matvejchikov Ilya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4786556C.8040108@freescale.com \
--to=scottwood@freescale.com \
--cc=hs@denx.de \
--cc=jeff@garzik.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.